From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86584 invoked by alias); 12 Jan 2017 17:32:35 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 86519 invoked by uid 89); 12 Jan 2017 17:32:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*r:10.10.10, gpg, GPG, H*i:sk:6d5d628 X-HELO: mail.thinkmo.de Received: from s1n.thinkmo.de (HELO mail.thinkmo.de) (213.239.209.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jan 2017 17:32:24 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.thinkmo.de (Postfix) with ESMTP id 3tzt9w5ljpzyhY for ; Thu, 12 Jan 2017 17:32:20 +0000 (UTC) Received: from mail.thinkmo.de ([127.0.0.1]) by localhost (mail.thinkmo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9tzi08U5_McM for ; Thu, 12 Jan 2017 17:32:20 +0000 (UTC) Received: from [10.10.10.145] (HSI-KBW-085-216-009-254.hsi.kabelbw.de [85.216.9.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.thinkmo.de (Postfix) with ESMTPSA id 3tzt9w4b9NzyQS for ; Thu, 12 Jan 2017 17:32:20 +0000 (UTC) Subject: Re: borgbackup test fail on cygwin (only) - cygwin pipe issues? To: cygwin@cygwin.com References: <8d66dac6-689d-972f-d06a-f4c1869b6b87@waldmann-edv.de> <6d5d6289-ea61-cd18-fb48-c5053f292e0f@gmail.com> From: Thomas Waldmann Openpgp: id=6D5BEF9ADD2075805747B70F9F88FB52FAF7B393 Message-ID: Date: Thu, 12 Jan 2017 17:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <6d5d6289-ea61-cd18-fb48-c5053f292e0f@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00127.txt.bz2 >> https://github.com/borgbackup/borg/issues/1268 > > Are your pipe handles in open in binary mode or text mode? You should > always ensure they are in binary mode. That was my first idea also. https://github.com/borgbackup/borg/blob/1.0.9/borg/remote.py#L188 this is the place where the ssh subprocess is forked and the pipes are set up. There is nothing special about binary mode there, but as mentioned in that ticket, I just tried it out to send binary data over such pipes and it worked: https://github.com/borgbackup/borg/issues/1268#issuecomment-239923192 (that \n should get modified to \r\n if in text mode, but it got through "as is") -- GPG ID: 9F88FB52FAF7B393 GPG FP: 6D5B EF9A DD20 7580 5747 B70F 9F88 FB52 FAF7 B393 -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple