public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Thomas Wolff <towo@towo.net>
To: cygwin@cygwin.com
Subject: Re: unzip failure with files that contain colons
Date: Thu, 16 Jun 2022 06:22:38 +0200	[thread overview]
Message-ID: <ba73b31b-be25-fe58-98de-11d8cad679cd@towo.net> (raw)
In-Reply-To: <20220615183007.7xchz44wwbx2gnio@lucy.dinwoodie.org>


Am 15.06.2022 um 20:30 schrieb Adam Dinwoodie:
> Cygwin generally handles filenames with colons just fine, by mapping the
> character to some higher Unicode character and remapping on the fly.
> However Cygwin's `unzip` appears to have a bug: when unzipping an
> archive that contains a filename with a colon, it replaces the colon
> with an underscore.
>
> cygcheck.out and simple test script attached; expected behaviour from
> running `bash unzip-bug.sh` is that you get an empty file called `a:b`,
> but on Cygwin you instead get an empty file called `a_b`.
It's an explicit #ifdef __CYGWIN__ in upstream unzip, file unix/unix.c, 
which transforms a bunch of characters.
If I uncomment most of them (except \), all unpack fine:
x0:z  x1<z  x2>z  x3|z  x4"z  x5?z  x6*z

Someone should report upstream please.
Thomas

  reply	other threads:[~2022-06-16  4:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 18:30 Adam Dinwoodie
2022-06-16  4:22 ` Thomas Wolff [this message]
2022-06-16 15:29   ` Takashi Yano
2022-06-16 15:50     ` Eliot Moss
2022-06-16 16:44       ` Takashi Yano
2022-06-18 20:23       ` Andrey Repin
2022-06-17  7:20     ` Adam Dinwoodie
     [not found]     ` <CAKwdsS-ZDR_ZFAkVwPci4mdcYcjONN_yoSb5sLxK678RRgfVmA@mail.gmail.com>
2022-06-18 23:40       ` unzip failure to recognize '--' Takashi Yano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba73b31b-be25-fe58-98de-11d8cad679cd@towo.net \
    --to=towo@towo.net \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).