public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: "Houder" <houder@xs4all.nl>
To: cygwin@cygwin.com, "Thomas Wolff" <towo@towo.net>
Subject: Re: [ANNOUNCEMENT] Update: mintty 2.1.2
Date: Sat, 25 Jul 2015 17:03:00 -0000	[thread overview]
Message-ID: <be0351be5e3aa7b7ba980fc25f9cce0c.squirrel@oude-webmail.xs4all.nl> (raw)
In-Reply-To: <55B2B644.8010506@towo.net>

>> Hi Thomas,
>>> Maybe setsid() should not be called if fork() fails...
>>> Could you try this please:
>>>     if (daemonize && !isatty(0)) {
>>>       int pid = fork();
>>>       if (pid > 0) exit(0);    // exit parent process
>>>       if (pid == 0) setsid();  // detach child process
>>>       if (pid < 0) {
>>>         error("could not detach from caller");
>>>         exit(9);
>>>       }
>>>     }
>> Hint: source code of setsid.c -- util-linux package)
> ... or maybe the parent thread should not exit immediately but wait:
>    if (daemonize && !isatty(0)) {
> #include <sys/wait.h>
>      int status;
>      int pid = fork();
>      if (pid > 0) {
>        waitpid(pid, &status, 0);
>        exit(0);
>      }
>      setsid();
>    }
>
> Can you please try both alternatives?

Hi Thomas,

I found the bug (more or less): it is me (AND you). More will follow soon.

Henri


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  reply	other threads:[~2015-07-25 17:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 22:41 Thomas Wolff
2015-07-24  7:50 ` Houder
2015-07-24 11:40   ` Thomas Wolff
2015-07-24 13:18     ` Houder
2015-07-24 13:25       ` Houder
2015-07-24 13:34       ` Corinna Vinschen
2015-07-24 22:03       ` Thomas Wolff
2015-07-25 17:03         ` Houder [this message]
2015-07-25 20:15           ` Houder
2015-07-26 11:09             ` Houder
2015-07-26 11:58               ` Houder
2015-07-26 16:53                 ` Thomas Wolff
2015-07-26 22:59                   ` Houder
2015-07-27 10:54                     ` Houder
2015-07-27 15:58                       ` Houder
2015-07-27 17:44                         ` Thomas Wolff
2015-07-27 19:29                           ` Corinna Vinschen
2015-07-27 20:44                             ` Houder
2015-07-27 20:58                               ` Houder
2015-07-27 20:59                               ` Corinna Vinschen
2015-07-27 21:14                                 ` Houder
2015-07-27  7:17             ` Csaba Raduly
2015-07-27  8:50               ` Houder
2015-07-24 13:25     ` Corinna Vinschen
2015-07-27 18:08 ` Buchbinder, Barry (NIH/NIAID) [E]
2015-07-27 22:01   ` Thomas Wolff
2015-07-30 12:00 ` Kptain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be0351be5e3aa7b7ba980fc25f9cce0c.squirrel@oude-webmail.xs4all.nl \
    --to=houder@xs4all.nl \
    --cc=cygwin@cygwin.com \
    --cc=towo@towo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).