From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46839 invoked by alias); 2 Sep 2016 07:09:30 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 46827 invoked by uid 89); 2 Sep 2016 07:09:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.8 required=5.0 tests=BAYES_50,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=fish, confd, workarounds, conf.d X-HELO: blaine.gmane.org Received: from Unknown (HELO blaine.gmane.org) (195.159.176.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Sep 2016 07:09:19 +0000 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bfib5-0003fH-MJ for cygwin@cygwin.com; Fri, 02 Sep 2016 09:09:07 +0200 To: cygwin@cygwin.com From: Andrew Schulman Subject: Re: fish Remove unneeded workarounds in /etc/fish/conf.d/cygwin.fish Date: Fri, 02 Sep 2016 07:09:00 -0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Archive: encrypt X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00021.txt.bz2 > The cygwin-specific file /etc/fish/config.d/cygwin.fish has this section: > > # Work around an autocompletion bug, where fish tries to execute strings > # in parentheses in the PATH. For example it tries to run the x86 function > # if it sees a PATH component like '/cygdrive/c/Program Files (x86)'. > # See https://github.com/fish-shell/fish-shell/issues/952#issuecomment-27499216 > . > # Work around the most common cases here. > > function R --description "print '(R)'" > echo '(R)' > end > function tm --description "print '(tm)'" > echo '(tm)' > end > function TM --description "print '(TM)'" > echo '(TM)' > end > function x86 --description "print '(x86)'" > echo '(x86)' > end > function X86 --description "print '(X86)'" > echo '(X86)' > end > > This was to work around fish bug > https://github.com/fish-shell/fish-shell/issues/952. However, this bug > was fixed in version 2.3.0. I tested this quickly by removing the > workaround and fish seemed to complete paths swimmingly (heh). > > I suggest this section is removed from fish-2.3.1 as these workarounds > are no longer needed. > Thanks, Matt Thanks for pointing that out. Yep, I checked and they don't seem to be needed any more. I'll remove them and put out a new point release. Andrew -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple