From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <markus.hoenicka@mhoenicka.de>
Received: from smtprelay01.ispgateway.de (smtprelay01.ispgateway.de
 [80.67.18.13])
 by sourceware.org (Postfix) with ESMTPS id 691933858D35
 for <cygwin@cygwin.com>; Mon,  4 May 2020 11:20:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 691933858D35
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=mhoenicka.de
Authentication-Results: sourceware.org;
 spf=none smtp.mailfrom=markus.hoenicka@mhoenicka.de
Received: from [134.119.228.1] (helo=webmail.df.eu)
 by smtprelay01.ispgateway.de with esmtpa (Exim 4.92.3)
 (envelope-from <markus.hoenicka@mhoenicka.de>)
 id 1jVZ9B-0008Fx-O0; Mon, 04 May 2020 13:20:29 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 04 May 2020 13:20:29 +0200
From: Markus Hoenicka <markus.hoenicka@mhoenicka.de>
To: Marco Atzeri <marco.atzeri@gmail.com>
Cc: cygwin@cygwin.com
Subject: Re: R does not handle package non-ASCII DESCRIPTION files properly
In-Reply-To: <22ac49be-c6af-12ef-7f93-56b7151d08a3@gmail.com>
References: <9164cff70d13d9f7ca451f42fc868a14@mhoenicka.de>
 <129c4e64-4051-0cc2-0706-c39eaacbdc9e@gmail.com>
 <22ac49be-c6af-12ef-7f93-56b7151d08a3@gmail.com>
Message-ID: <e4d82580fcca98f886b856344fac87d6@mhoenicka.de>
X-Sender: markus.hoenicka@mhoenicka.de
User-Agent: Roundcube Webmail
X-Df-Sender: bWFya3VzLmhvZW5pY2thQG1ob2VuaWNrYS5kZQ==
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cygwin@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <http://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-request@cygwin.com?subject=help>
List-Subscribe: <http://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Mon, 04 May 2020 11:20:41 -0000

Am 2020-05-01 12:44, schrieb Marco Atzeri via Cygwin:
> Am 30.04.2020 um 22:17 schrieb Marco Atzeri:
>> Am 30.04.2020 um 17:28 schrieb Markus Hoenicka:
>>> Hi,
>>> 
>>> I've contacted the processx package maintainer on a problem reported 
>>> here previously (see 
>>> https://cygwin.com/pipermail/cygwin/2020-April/244667.html). He 
>>> suggested to try the github version but that triggered a different 
>>> type of error which does not seem to be package-specific.
> 
> the original problem is caused by the lack of $(LIBR)
> after $(CLIENT_OBJECTS) in src/Makevars
> 
> Cygwin as Windows need the link library after the objects.
> 
> $ grep SHLIB_LINK Makevars*
> Makevars:       $(SHLIB_LINK) -o client$(SHLIB_EXT) $(CLIENT_OBJECTS)
> $(PKG_LIBS)
> Makevars.win:   $(SHLIB_LINK) -o client$(SHLIB_EXT) $(CLIENT_OBJECTS)
> $(LIBR) $(SHLIB_LIBADD) $(PKG_LIBS)
> 
> 
> the documentations
> 
> https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Using-Makevars
> 
> suggest the form
> 
> $(SHLIB): $(OBJECTS)
>         $(SHLIB_LINK) -o $ $(OBJECTS) $(ALL_LIBS)
> 
> and this should work as
>  /usr/lib/R/etc/Makeconf
> defines
> 
> ALL_LIBS = $(PKG_LIBS) $(SHLIB_LIBADD) $(LIBR) $(LIBINTL) $(LIBS)
> 
> 
> so try with
> $(SHLIB_LINK) -o client$(SHLIB_EXT) $(CLIENT_OBJECTS) $(ALL_LIBS)

Hi Marco,

thanks for looking into this. I can confirm that the processx package 
compiles just fine with the modification of Makevars that you suggested. 
I'll report this to the processx maintainer and ask him to fix this.

regards,
Markus

-- 
Markus Hoenicka
http://www.mhoenicka.de
AQ score 38