From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) by sourceware.org (Postfix) with ESMTPS id E398F3858D32 for ; Tue, 2 Jan 2024 22:18:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E398F3858D32 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=kylheku.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=shaw.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E398F3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=3.97.99.32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704233900; cv=none; b=oxs+z3cpFV+Ou5/F9Vr8NzDRUOMlJxzCtDFjFJZlQOgfuxqvn+NNym2PCN9L6X4lyVzF2cAUGbi9CRzaeU/m20Bs1zk2kE5P8O6Cy9X576ZNt52hykDpCN8/DyLgssnGCR7nlGMtH5lHHYJp8u9b7xzzPRf4WKRHXMCqxuPtGKA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704233900; c=relaxed/simple; bh=0BXe7LtnCx6dPmf4DuuI/RKbP6B25TWq30xO0KF6Lt0=; h=DKIM-Signature:MIME-Version:Date:From:To:Subject:Message-ID; b=H+83GRRUYnq/nq/GmZ93gk4zrGPfvW1K1oZ+tC09Veei69mTgOCGD31K/BFMRHTpd09wityrxat/9xiduA+tl9C5M6c07wqzVv/2X5/V3P/7kdvekh6QRSXhmZ7QbAnHfRhp4kruN/6eVisZpxrEkG2E8aZuqOBa6Rd/bevybzc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id Kg9GrRJVB8jpTKn5VrkH3O; Tue, 02 Jan 2024 22:18:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=shaw.ca; s=s20180605; t=1704233897; bh=0BXe7LtnCx6dPmf4DuuI/RKbP6B25TWq30xO0KF6Lt0=; h=Date:From:To:Subject; b=Z6Hm7iNDESL/u5VWw2sXeMtMart1kks25VP9cq7CMNSovsefK3cipdor+pyLLffPk IOjW5TU2C3JZp8IF2B0OarQUz/VCRK+uNO46hLUBNe16CgOF+Y0RZSjR5XOSSNXkFb 1hJTp/W3VmM/K8tPkpDUs84K4iEQmmvMlJv+xd2VbeSGfFaQrY4vht/RCjB6vsgDCm 1HjHLjEWW0SloKrEmLsadhZR4NGsf8I0muh1a1b4WJAuMSQo7hewqwzAdIWUykFkqg JhTvSgV2VvkyvCd+7xixBXREADhvo+NbwULmOdRdizC9USgG5rNw/CMWzsrAnh/39t oCQg+QXXXj5Ow== Received: from kylheku.com ([70.79.182.7]) by cmsmtp with ESMTPSA id Kn5UrbLCPMsNfKn5UrbFrF; Tue, 02 Jan 2024 22:18:17 +0000 Authentication-Results: ; auth=pass (PLAIN) smtp.auth=kkylheku@shaw.ca X-Authority-Analysis: v=2.4 cv=KJNJsXJo c=1 sm=1 tr=0 ts=65948ba9 a=pMSlDXUwMa7SJ1EIez8PdQ==:117 a=pMSlDXUwMa7SJ1EIez8PdQ==:17 a=xqWC_Br6kY4A:10 a=dEuoMetlWLkA:10 a=JxO-F9HAsX61K3wg56AA:9 a=CjuIK1q_8ugA:10 a=qftUfvFSv24jhhKMgwsA:9 a=_W_S_7VecoQA:10 a=QEXdDO2ut3YA:10 Received: from localhost ([::1] helo=mail.kylheku.com) by kylheku.com with esmtp (Exim 4.94.2) (envelope-from ) id 1rKn5T-006aIL-5S for cygwin@cygwin.com; Tue, 02 Jan 2024 14:18:15 -0800 MIME-Version: 1.0 Date: Tue, 02 Jan 2024 14:18:15 -0800 From: Kaz Kylheku To: cygwin@cygwin.com Subject: Possibly buggy use of ctype.h macros. User-Agent: Roundcube Webmail/1.4.15 Message-ID: X-Sender: kaz@kylheku.com Content-Type: multipart/alternative; boundary="=_bf4bf567708047fb6e0d6bb2b17b3cb2" X-CMAE-Envelope: MS4xfMaqiMkrozWqzE6t+xEMBLxYt/zON/7Y9APP2y23gDN8BqbJ6zjYYC6Ihs9Se4LSqaU1uKQ9Lgq3SWv9T2kr3naaxImUhwpRMeZ5TT6Ac2My9KZDPEz4 p+8iVPFN3xuS0K6UMaur5bcm30H89Z3a7EznBA9pRiY4vVGpbOksl2yD X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=_bf4bf567708047fb6e0d6bb2b17b3cb2 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Hi All, I noticed that this macro, defined in winsup/cygwin/local_includes/path.h: #define isdrive(s) (isalpha (*(s)) && (s)[1] == ':') is being used with arguments of type char, like dereferenced "char *" pointers. Unless the isalpha implementation is robust against this, it should be isalpha((unsigned char) *(s)). --=_bf4bf567708047fb6e0d6bb2b17b3cb2--