From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
To: cygwin@cygwin.com
Subject: Re: cpp /usr/include/threads.h fails; modfl segfaults
Date: Sun, 30 Aug 2020 14:39:31 -0600 [thread overview]
Message-ID: <eba28e06-139b-0d01-afb5-81a67ba1ad16@SystematicSw.ab.ca> (raw)
In-Reply-To: <20200830130005.GR3272@calimero.vinschen.de>
On 2020-08-30 07:00, Corinna Vinschen wrote:
> On Aug 29 08:52, airplanemath via Cygwin wrote:
>> I have two reports. A brief description of the system:
>> $ uname -a | sed "s/${HOSTNAME}/\${HOSTNAME}/g"
>> CYGWIN_NT-10.0 ${HOSTNAME} 3.1.7(0.340/5/3) 2020-08-22 17:48 x86_64 Cygwin
...
>> $ cat test.c
>> #include <math.h>
>> #include <stdio.h>
>> #include <stdlib.h>
>>
>> int main(int argc, char *argv[]) {
>> long double a, b, c;
>> char *num_end = NULL;
>> a = b = c = 0.0L;
>> if (argc != 2) {
>> fprintf(stderr, "Usage: %s NUMBER\n", argv[0]);
>> exit(1);
>> }
>> a = strtold(argv[1], &num_end);
>> b = modfl(a, &c);
>> printf("%Lf %Lf %Lf\n", a, b, c);
>> return 0;
>> }
>
> This is a bug in the assembler code taken from Mingw-w64. The bug has
> been fixed upstream, so I just pulled in the upstream fixes.
The 64 bit fix doesn't pop eax but *now* flags eax as clobbered, whereas the 32
bit fix both pops and *now* flags eax as clobbered, which it really doesn't need
to do. Is this inconsistent treatment correct?
diff --git a/winsup/cygwin/math/modfl.c b/winsup/cygwin/math/modfl.c
index af75a8b..ef1ab16 100644 (file)
--- a/winsup/cygwin/math/modfl.c
+++ b/winsup/cygwin/math/modfl.c
@@ -21,7 +21,7 @@ modfl (long double value, long double* iptr)
"fldcw (%%rsp)\n"
"frndint\n"
"fldcw 4(%%rsp)\n"
- "addq $8, %%rsp\n" : "=t" (int_part) : "0" (value)); /* round */
+ "addq $8, %%rsp\n" : "=t" (int_part) : "0" (value) : "eax"); /* round */
#elif defined(_X86_) || defined(__i386__)
asm ("push %%eax\n\tsubl $8, %%esp\n"
"fnstcw 4(%%esp)\n"
@@ -31,7 +31,7 @@ modfl (long double value, long double* iptr)
"fldcw (%%esp)\n"
"frndint\n"
"fldcw 4(%%esp)\n"
- "addl $8, %%esp\n\tpop %%eax\n" : "=t" (int_part) : "0" (value)); /* round */
+ "addl $8, %%esp\n\tpop %%eax\n" : "=t" (int_part) : "0" (value) : "eax");
/* round */
#else
int_part = truncl(value);
#endif
--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]
next prev parent reply other threads:[~2020-08-30 20:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <02b16d2e-9d51-de58-807b-3b31b2565b59.ref@aol.com>
2020-08-29 12:52 ` airplanemath
2020-08-29 17:57 ` Ken Brown
2020-08-29 21:41 ` [QUAR] " Eliot Moss
2020-08-30 16:11 ` Ken Brown
2020-08-30 18:21 ` Eliot Moss
2020-08-30 1:21 ` airplanemath
2020-08-30 2:56 ` Ken Brown
2020-08-30 6:23 ` ASSI
2020-08-30 20:07 ` Brian Inglis
2020-08-30 13:00 ` Corinna Vinschen
2020-08-30 19:21 ` airplanemath
2020-08-31 7:33 ` Corinna Vinschen
2020-08-30 20:39 ` Brian Inglis [this message]
2020-08-31 7:35 ` Corinna Vinschen
2020-08-31 15:37 ` Brian Inglis
2020-08-31 18:45 ` Corinna Vinschen
2020-08-31 19:24 ` Brian Inglis
2020-08-31 19:41 ` Corinna Vinschen
2020-09-01 17:28 ` Brian Inglis
2020-09-02 7:54 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eba28e06-139b-0d01-afb5-81a67ba1ad16@SystematicSw.ab.ca \
--to=brian.inglis@systematicsw.ab.ca \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).