From: Jon Turney <jon.turney@dronecode.org.uk>
To: The Cygwin Mailing List <cygwin@cygwin.com>
Subject: Re: [PATCH cygport 1/2] postinst: Never remove an existing .gnu_debuglink
Date: Tue, 1 Feb 2022 20:33:10 +0000 [thread overview]
Message-ID: <eef4ada5-0ace-d828-c163-988390aa35e0@dronecode.org.uk> (raw)
In-Reply-To: <YfmIbMQvjqL8yW3S@calimero.vinschen.de>
On 01/02/2022 19:22, Corinna Vinschen wrote:
> Hi Jon,
>
> On Feb 1 17:25, Jon Turney wrote:
>> Be more careful not to remove an existing .gnu_debuglink, even if we
>> think this package has no useful debug symbols.
>>
>> (Some versions of 'llvm-objdump -l' fail to find line number info even
>> though it's there. Don't break a package which manages it's own debug
>> symbols (e.g. cygwin) when that happens.)
>> ---
>> lib/src_postinst.cygpart | 28 ++++++++++++++++++----------
>> 1 file changed, 18 insertions(+), 10 deletions(-)
>>
>> diff --git a/lib/src_postinst.cygpart b/lib/src_postinst.cygpart
>> index d8bb226..e29b2cb 100644
>> --- a/lib/src_postinst.cygpart
>> +++ b/lib/src_postinst.cygpart
>> @@ -1051,23 +1051,31 @@ __prepstrip() {
>>
>> lines=$(${objdump} -d -l "${exe}" 2>/dev/null | sed -ne "s|.*\(/usr/src/debug/${PF}/.*\):[0-9]*$|\1|gp" | sort -u | tee -a ${T}/.dbgsrc.out | wc -l);
>
> Shouldn't lines be computed *after* the new check for .gnu_deb? After
> all, it's still pretty time-consuming and if the .gnu_deb check kicks in
> it's never tested...
The objdump invocation has the side effect of creating ${T}/.dbgsrc.out,
which is later used to determine what source files to put into the
debuginfo package.
parent reply other threads:[~2022-02-01 20:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <YfmIbMQvjqL8yW3S@calimero.vinschen.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eef4ada5-0ace-d828-c163-988390aa35e0@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).