From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) by sourceware.org (Postfix) with ESMTPS id 099783858D37 for ; Sun, 27 Feb 2022 11:54:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 099783858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bernhard-voelker.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=bernhard-voelker.de Received: from [192.168.101.10] ([93.218.103.193]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MsZ7T-1oC8jL1p07-00u2Gz; Sun, 27 Feb 2022 12:54:24 +0100 Message-ID: Date: Sun, 27 Feb 2022 12:54:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: Patches to findutils 4.9.0-1's updatedb to do locking, allow filenames with spaces & progress monitoring, exclude /dev on Cygwin, etc. Content-Language: en-US To: Dan Harkless , bug-findutils@gnu.org, cygwin@cygwin.com References: <986736274.144968.1630167325057.ref@mail.yahoo.com> <986736274.144968.1630167325057@mail.yahoo.com> <3457cee1-18b5-2916-adee-afdfaf9769ea@t-online.de> <525a832a-78fd-5a32-e195-5747120da922@harkless.org> <88b29ca4-313f-2318-c2ed-b55f86aafac0@harkless.org> From: Bernhard Voelker In-Reply-To: <88b29ca4-313f-2318-c2ed-b55f86aafac0@harkless.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:cNoG0t/z97mBC+vAqg85IidosZqyOLl5Gtq5qOwVvfiGNMTMME6 vGS96e0KHLi0rBymbYKtSt7q5xxeDd1UkDJGDT3MxmbUhuCTzcTTPHrKAIQiEhGF7z6Ayje le2J/br11RnCHBKSWF7MFb035lCbuUrHcgb3DR0UbUjEYXChL8uRVmYds1LF/Z1JLk5v4d+ RZXKEGBQzoZ+9eGgAm/+g== X-UI-Out-Filterresults: notjunk:1;V03:K0:HL5AaYXO9DE=:QIVJfGs+NT7QjApLx2amw8 bRt18gkAkt2d2V6hlM2p6Re/CfWLZ8xzK9yUPJziaz3UrToCs9p2P2wnSwa9xNcmim0uxpxOg ckA77Y3RTnonBfuLsw/HWDviuebvHdI1hHJxlFGl7WI2J8TuMLXuoQUdt6mPf1B2XFeu68knj iH7F3NWWLONYxtJ40lRb09b1PlYReh1QT3u2DRhIsWWdL8DRZGGlhFSo9iqE2YJBE9IgupWji zqrHMs7mpTVJ2pfS6fyHtuvZ1QmXD8Lb90Nl1U1XNk3ivxwrDmrDj5qEbNKD/OaIgsp9aVnlp BNgLGv2YlLAG8D+e3F4wHoqLJqbQxsHB3S7GUgV/CO7Dx9OhwUy4zUDvZuoL/039hi7MEIQ7V i7ihJCiOx+U5n92qnWJ+vpgBWvuoKfdi5WOm9ftBL58QWqNMC4z8rwc/vJBjFlysC50gh84vC uLfPfRH80Rh6ch3UsPjrv1fmJFHVodOabJeRU3+lyATB09PzmuQsvIhys9tJZ3Dn5P/OBqdqk iJXw+2CkJWyAcLn45A2M6DymEJpPupw6wCEbzapcnYJqFObAxW59XaHDzqcTPCFVCksfY4yW3 GE9AMVnUFFhqmKUaPyowt/GdgZ93YgqS9RPPMia/SPC31ZszS5hI41ITExkCEnwrKTGk7vMzb y9zwX0P/hrWWWbpoVQ7w/zQ/n5403lYYC47Ym0VSllu3xzRKqGSNeeEAKwF+qhbqsvIkiRf/E +HAmAwEFrT3YczE9 X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Feb 2022 11:54:38 -0000 On 2/24/22 17:32, Dan Harkless wrote: > I'm finally getting around to sending in a patch (to bug-findutils and > the Cygwin list, to which I'm currently subscribed) to address these > issues, along with some others, a few of which represent small changes > in behavior: Thanks for the patch ... but: a) The patch does not cleanly apply: ~/findutils/locate> patch -t < /tmp/updatedb.patch patching file updatedb Reversed (or previously applied) patch detected! Assuming -R. Hunk #2 succeeded at 47 with fuzz 2. Hunk #7 FAILED at 167. Hunk #8 FAILED at 202. Hunk #9 succeeded at 217 (offset -2 lines). Hunk #10 succeeded at 276 (offset -2 lines). 2 out of 10 hunks FAILED -- saving rejects to file updatedb.rej b) The patch changes the file 'updatedb' which is created at build time instead of the file 'updatedb.sh' which is under version control. c) The description says that there are 10 more or less non-trivial changes in it. A squashed diff of 500 lines on a file with 342 lines makes reviewing and discussing of each topic impossible. Would you mind re-sending as separate Git patches? Have a nice day, Berny