From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94190 invoked by alias); 13 Aug 2018 22:16:22 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 94095 invoked by uid 89); 13 Aug 2018 22:16:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=emailing, intend, grrr, blake X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Aug 2018 22:16:20 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84B61401DE92 for ; Mon, 13 Aug 2018 22:16:18 +0000 (UTC) Received: from [10.10.122.177] (ovpn-122-177.rdu2.redhat.com [10.10.122.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5769E1C716 for ; Mon, 13 Aug 2018 22:16:18 +0000 (UTC) Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.11.0-0.1 To: cygwin@cygwin.com References: <20180810114254.GA25560@calimero.vinschen.de> <57b3092a9b5027be5f14e59c305200bc@smtp-cloud8.xs4all.net> <71f1280d04f70e8b74cfce78ba5690d3@xs4all.nl> From: Eric Blake Message-ID: Date: Mon, 13 Aug 2018 22:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <71f1280d04f70e8b74cfce78ba5690d3@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00156.txt.bz2 On 08/13/2018 04:29 PM, Houder wrote: >> The modication would require changing: >> >> winsup/cygwin/fenv.cc (_feinitialise() ) >> winsup/cygwin/include/fenv.h (FE_ALL_EXCEPT) > > GRRR! The file encoding of fenv.h is "cp1252" because of 2 characters in > this > line: > >      Intel® 64 and IA-32 Architectures Software Developer’s Manuals: > > ... part of a comment at the beginning of the file. > > (the registered trademark sign (u00ae) is encoded as 0xae (cp1252), > while it >  would be: 0xc2 0xae, in utf-8, >  the right single quotation mark (u2019) is encoded as 0x92 (cp1252), > but in >  utf-8 it would be: 0xc2 0x80 0x98) > > I intend to convert the file encoding of fenv.h to utf-8. Is that a "No-No" > or is it allowed? (I assume GIT will notice). In general, git doesn't care if you change a file's encoding - that's just another content change. In practice, you may get weird effects when viewing that particular patch (as the patch is not well-formed in the new multibyte locale, and looks funky when displayed in the old locale), and emailing a patch may require care in telling git which encoding to use for the email; but that's cosmetic, and shouldn't matter in the long run. Updating the code base to uniformly use UTF-8 seems reasonable to me. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple