From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78976 invoked by alias); 16 Oct 2015 12:30:23 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 78937 invoked by uid 89); 16 Oct 2015 12:30:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,FSL_HELO_BARE_IP_2,RCVD_IN_DNSWL_LOW,RCVD_NUMERIC_HELO,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: plane.gmane.org Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 16 Oct 2015 12:30:18 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Zn497-0003Uf-TN for cygwin@cygwin.com; Fri, 16 Oct 2015 14:30:06 +0200 Received: from 193.191.180.236 ([193.191.180.236]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 16 Oct 2015 14:30:05 +0200 Received: from johan.laenen+cygwin by 193.191.180.236 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 16 Oct 2015 14:30:05 +0200 To: cygwin@cygwin.com From: Johan Laenen Subject: Re: Https proxy auth issue with git in cygwin 2.2.1 Date: Fri, 16 Oct 2015 12:30:00 -0000 Message-ID: References: <20150921103100.GF14466@dinwoodie.org> <20151005202249.GM14466@dinwoodie.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit User-Agent: Loom/3.14 (http://gmane.org/) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00221.txt.bz2 Adam Dinwoodie dinwoodie.org> writes: > I think I've found the problem, and you're right -- Git has changed the > way it makes the curl call. The culprit is commit 5841520b in the > upstream Git repository, which has the following commit message: > > | http: always use any proxy auth method available > | > | We set CURLOPT_PROXYAUTH to use the most secure authentication > | method available only when the user has set configuration variables > | to specify a proxy. However, libcurl also supports specifying a > | proxy through environment variables. In that case libcurl defaults > | to only using the Basic proxy authentication method, because we do > | not use CURLOPT_PROXYAUTH. > | > | Set CURLOPT_PROXYAUTH to always use the most secure authentication > | method available, even when there is no git configuration telling us > | to use a proxy. This allows the user to use environment variables to > | configure a proxy that requires an authentication method different > | from Basic. > > I can't confirm this is the problem, though, as I don't have a test > environment that uses NTLM. > > Do you have the ability to either run a test version of Git I can > produce that patches out this change, or (better) to build Git yourself > without this patch to see if that is indeed the change that's causing > the problem? > Hi There, I can into the exact same problem after upgrading to the latest cygwin version. So, following your advice, I took git-2.6.1.tar.gz from github, untarred, and modified http.c: $ diff git-2.6.1/http.c t/git-2.6.1/http.c 466,467c466,468 < if (curl_http_proxy) { < curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy); --- > if (curl_http_proxy) { > curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy); > } 469c470 < curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY); --- > curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY); 471d471 < } One make configure, ./configure, make and make install I can confirm that unpatching the change undoes the problem :) > Adam > > Johan -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple