From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87381 invoked by alias); 29 Dec 2015 05:16:36 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 87363 invoked by uid 89); 29 Dec 2015 05:16:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=pardon, H*f:6YU5bgvKp2ENv, H*f:CALiPeun3v, UD:Brian.Inglis X-HELO: plane.gmane.org Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 29 Dec 2015 05:16:34 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aDme6-0000e1-7c for cygwin@cygwin.com; Tue, 29 Dec 2015 06:16:30 +0100 Received: from S010690fba62c4bda.cg.shawcable.net ([96.51.88.197]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Dec 2015 06:16:30 +0100 Received: from Brian.Inglis by S010690fba62c4bda.cg.shawcable.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Dec 2015 06:16:30 +0100 To: cygwin@cygwin.com From: Brian Inglis Subject: Re: Issues in utmp/utmpx headers Date: Tue, 29 Dec 2015 05:16:00 -0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit User-Agent: Loom/3.14 (http://gmane.org/) X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00343.txt.bz2 > > David Lee gmail.com> writes: > >> While trying to port bsdgames to Cygwin I spotted the following issues: > >> (1) In /usr/include/utmpx.h, utmpxname() is declared a void function. > >> Should it return int? > >> (2) In /usr/include/sys/utmp.h, utmpname() is declared a void > >> function. Should it return int? > >> (3) _PATH_UTMPX is not defined in any system headers. > On 28 December 2015 at 03:02, Brian Inglis > systematicsw.ab.ca> wrote: > > Search packages for missing files e.g. > > https://cygwin.com/cgi-bin2/package-grep.cgi?grep=utmp.h&arch=x86_64 > > brings up package cygwin-devel and cygwin32. > > Download and run setup and select cygwin-devel to install the headers and > > libraries. David Lee gmail.com> writes: > The issue isn't missing, not-installed packages. The issues are (1) > some function declaration seem wrong; and (2) a constant is missing. Pardon my reading comprehension bork! The utmpname implementation in newlib-cygwin/winsup/cygwin/syscalls.cc could probably be improved to: avoid a memory leak; return -1 if strdup fails, zero otherwise; default the path if a null pointer or string argument is passed. That would also fix utmpxname which is an alias. Such a change would have little likely impact on downstream apps, but could produce warnings about ignoring return values. Unfortunately there appears to be no standard defined names to access the default file name although GNU and Cygwin provide UTMP_FILE and UTMPX_FILE; GNU also provide UTMP_FILENAME and UTMPX_FILENAME. _PATH_UTMP and _PATH_UTMPX are implementation reserved names which may or may not be provided, though adding the latter in paths.h would be trivial. As the developers say, patches always welcome. -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple