public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Andrew Schulman <schulman.andrew@epa.gov>
To: cygwin@cygwin.com
Subject: Re: pinfo configure problem - configure.ac (0/1)
Date: Tue, 13 May 2014 21:15:00 -0000	[thread overview]
Message-ID: <og25n9d8s3vmasq7njj937u737r5lrhnh4@4ax.com> (raw)
In-Reply-To: <537275F3.6070108@redhat.com>

> On 05/13/2014 01:19 PM, Andrew Schulman wrote:
> 
> > 
> > AC_CHECK_CURSES calls AC_CHECK_CURSES_COMPILE, which is the step that
> > fails.  I've included it below.  The key step seems to be that it calls
> > AC_LINK_IFELSE, with the curses libs (-lncursesw) appended to LDFLAGS.
> 
> That's a bug in AC_CHECK_CURSES_COMPILE, and should be reported to
> whoever wrote that macro.  The autoconf manual says that LDFLAGS is for
> -L options, while LIBS is for -l options.

OK.  I think the author of pinfo is long gone, but I'll submit a patch
upstream in case someone is interested.

> > 
> > dnl
> > dnl check if the curses header we found, works
> > dnl
> > AC_DEFUN([AC_CHECK_CURSES_COMPILE], [
> > 
> >     dnl save CFLAGS and LDFLAGS and set new ones
> >     CFLAGS_OLD=$CFLAGS
> >     CFLAGS="$CFLAGS $curses_includes"
> >     LDFLAGS_OLD=$LDFLAGS
> >     LDFLAGS="$LDFLAGS $curses_libs"
> 
> and this is a blatant case of using the wrong env-var for library
> probing.  s/LDFLAGS/LIBS/ on these lines, before running autoreconf, and
> that should fix it without you manually having to pass LIBS= at the
> configure command line.

Sounds good.  Thanks again.
Andrew


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

      reply	other threads:[~2014-05-13 21:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 10:58 pinfo configure problem Andrew Schulman
2014-05-13 11:25 ` Corinna Vinschen
2014-05-13 11:52   ` Andrew Schulman
2014-05-13 11:57     ` Corinna Vinschen
2014-05-13 15:35       ` pinfo configure problem - configure.ac (1/1) Andrew Schulman
2014-05-13 16:54         ` Corinna Vinschen
2014-05-13 16:16       ` pinfo configure problem - configure.ac (0/1) Andrew Schulman
2014-05-13 17:29         ` Andrew Schulman
2014-05-13 18:54         ` Eric Blake
2014-05-13 19:25           ` Andrew Schulman
2014-05-13 19:54             ` Eric Blake
2014-05-13 21:15               ` Andrew Schulman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=og25n9d8s3vmasq7njj937u737r5lrhnh4@4ax.com \
    --to=schulman.andrew@epa.gov \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).