public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Andrew Schulman <schulman.andrew@epa.gov>
To: cygwin@cygwin.com
Subject: Re: [PATCH] Fix optional variables in libargp
Date: Fri, 18 Feb 2022 08:30:05 -0500	[thread overview]
Message-ID: <qq7v0h9f7r9vjo3sst8oqijvjsk0hfv0de@4ax.com> (raw)
In-Reply-To: <002a01ce86c6$ba32a190$2e97e4b0$%fedin@samsung.com>

>  Hello!
>  I have successfully tested it on i386. Really, just remove PREFIX
> completely and it's okay. GetProcAddress() appears to be "clever" and adds
> the leading underscope by itself on i386. I don't know what you did wrong
> and why you could not reproduce the solution.
>  However, i have one idea. After patching libargp you need to recompile your
> test case. Because it needs to pick up __declspec(dllexport).

Yes, I recompiled my example after rebuilding and reinstalling libargp.  It
still doesn't work.  I even rebooted too, to make sure I was using the
newly installed cygargp-0.dll and not a cached version.

I don't know why this should work for you, and not for me.  I'm attaching
here the revised patch of yours with PREFIX removed, and the argp-ex2.c
source file that I'm building.  Using this patch, I rebuild and reinstall
libargp.   Then I get

$ gcc -o argp-ex2 argp-ex2.c -largp
$ ./argp-ex2.exe --help
Usage: argp-ex2 [OPTION...]
Argp example #2 -- a pretty minimal program using argp

  -?, --help                 give this help list
      --usage                give a short usage message

Note there's no --version option or bug reporting email address.  Do you
get a different result?



      parent reply	other threads:[~2022-02-18 13:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 10:17 libargp: argp_program_version does not work Fedin Pavel
2013-07-11 16:35 ` Andrew Schulman
2013-07-11 22:02   ` Andrew Schulman
2013-07-12 14:52     ` Fedin Pavel
2013-07-12 15:36       ` Andrew Schulman
2013-07-17  9:57         ` [PATCH] Fix optional variables in libargp Fedin Pavel
2013-07-17 12:59           ` Eric Blake
2013-07-22  7:33           ` Andrew Schulman
2013-07-22  8:12             ` Pavel Fedin
2013-07-22 13:19             ` Pavel Fedin
2013-07-23 15:07               ` Andrew Schulman
2013-07-24  9:56                 ` Pavel Fedin
2022-02-18 13:30               ` Andrew Schulman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=qq7v0h9f7r9vjo3sst8oqijvjsk0hfv0de@4ax.com \
    --to=schulman.andrew@epa.gov \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).