From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102543 invoked by alias); 25 Apr 2018 13:11:09 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 102529 invoked by uid 89); 25 Apr 2018 13:11:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=BEFORE, oversight X-HELO: scan1.ztv.ne.jp Received: from scan1.ztv.ne.jp (HELO scan1.ztv.ne.jp) (61.198.53.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Apr 2018 13:11:02 +0000 Received: from localhost (localhost [127.0.0.1]) by proscan1.ztv.ne.jp (Postfix) with SMTP id C61848013661; Wed, 25 Apr 2018 22:10:59 +0900 (JST) Received: from ztvsmtp1.ztv.ne.jp (ztvsmtp1.ztv.ne.jp [210.236.160.101]) by scan1.ztv.ne.jp (Postfix) with ESMTP id 9D7C48013660; Wed, 25 Apr 2018 22:10:59 +0900 (JST) Received: from yak.mydns.jp (pc9163.amigo2.ne.jp [218.45.152.163]) by ztvsmtp1.ztv.ne.jp (Postfix) with ESMTP id 9261A685A; Wed, 25 Apr 2018 22:10:59 +0900 (JST) Received: from HORRIFIC.yak.scn.tv (unknown [192.168.129.250]) by yak.mydns.jp (Postfix) with ESMTPSA id EF6325C2F; Wed, 25 Apr 2018 22:10:58 +0900 (JST) Date: Wed, 25 Apr 2018 13:11:00 -0000 Message-ID: From: Yasutaka Atarashi To: cygwin@cygwin.com Subject: Re: subversion problem User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (i686-pc-mingw32) MULE/6.0 (HANACHIRUSATO) In-Reply-To: <77a982f8-d617-7a1d-2ac1-c0843ba30c94@acm.org> References: <9c2c7358137b4513a7b8f5fc08386354@vsrv060ex03.ssd.fsi.com> <77a982f8-d617-7a1d-2ac1-c0843ba30c94@acm.org> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2018-04/txt/msg00307.txt.bz2 Hi David, I had some doubt that the modification suggested in my mail: Cygwin subversion and UNC path https://cygwin.com/ml/cygwin/2018-04/msg00271.html would cause the failure. However, this would not be the case. I'm afraid to say that it seems to be an oversight in 05-retry-loop.patch. The first call of the loop target function must be made BEFORE the call of WIN32_RETRY_LOOP() while Cygwin branch of svn_io_file_rename2() calls WIN32_RETRY_LOOP() directly. I've made just simple tests only but applying the following patch additionally and replacing cygsvn_subr-1-0.dll seems to fix the issues. --- origsrc/subversion-1.10.0/subversion/libsvn_subr/io.c 2018-04-24 15:58:49.920742300 +0900 +++ src/subversion-1.10.0/subversion/libsvn_subr/io.c 2018-04-24 21:16:56.215447100 +0900 @@ -4294,6 +4294,7 @@ svn_io_file_rename2(const char *from_pat status = apr_file_rename(from_path_apr, to_path_apr, pool); } #elif defined (__CYGWIN__) + status = apr_file_rename(from_path_apr, to_path_apr, pool); WIN32_RETRY_LOOP(status, apr_file_rename(from_path_apr, to_path_apr, pool)); #else status = apr_file_rename(from_path_apr, to_path_apr, pool); Regards, Yasutaka ATARASHI -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple