From: Peter Bergner <bergner@linux.ibm.com>
To: Ian Lance Taylor <iant@google.com>,
"Paul E. Murphy" <murphyp@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] go: update usage of TARGET_AIX to TARGET_AIX_OS
Date: Thu, 22 Jun 2023 18:37:46 -0500 [thread overview]
Message-ID: <ddda663f-54de-e366-d05d-8fb5ad016e44@linux.ibm.com> (raw)
In-Reply-To: <CAKOQZ8wDWc7G5_jBNK1jvgChhiURceeAmZb5Bqrx_VZjeJP2Vw@mail.gmail.com>
On 6/16/23 12:01 PM, Ian Lance Taylor via Gcc-patches wrote:
> On Fri, Jun 16, 2023 at 9:00 AM Paul E. Murphy via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>> TARGET_AIX is defined to a non-zero value on linux and maybe other
>> powerpc64le targets. This leads to unexpected behavior such as
>> dropping the .go_export section when linking a shared library
>> on linux/powerpc64le.
>>
>> Instead, use TARGET_AIX_OS to toggle AIX specific behavior.
>>
>> Fixes golang/go#60798.
>>
>> gcc/go/ChangeLog:
>>
>> * go-backend.cc [TARGET_AIX]: Rename and update usage to
>> TARGET_AIX_OS.
>> * go-lang.cc: Likewise.
>
> This is OK.
>
> Thanks.
>
> Ian
I pushed this to trunk for Paul.
Peter
next prev parent reply other threads:[~2023-06-22 23:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 16:00 Paul E. Murphy
2023-06-16 16:00 ` [PATCH 2/2] rust: " Paul E. Murphy
2023-06-19 8:39 ` Thomas Schwinge
2023-06-21 16:20 ` Paul E Murphy
2023-06-22 23:38 ` Peter Bergner
2023-06-16 17:01 ` [PATCH 1/2] go: " Ian Lance Taylor
2023-06-22 23:37 ` Peter Bergner [this message]
2023-06-22 23:46 ` Peter Bergner
2023-06-23 3:30 ` Ian Lance Taylor
2023-06-30 17:28 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddda663f-54de-e366-d05d-8fb5ad016e44@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
--cc=murphyp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).