From: Mark Wielaard <mark@klomp.org>
To: "Martin Liška" <mliska@suse.cz>, debugedit@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>, dwz@sourceware.org
Subject: Re: [PATCH] Fail if dwz fails.
Date: Thu, 13 May 2021 16:07:58 +0200 [thread overview]
Message-ID: <0cfabb5c75508dc7dc419caa7c0e935ebc241bb3.camel@klomp.org> (raw)
In-Reply-To: <fb1b8ddc-38ff-cf3f-9474-cdcb46ecbef8@suse.cz>
Hi Martin,
On Thu, 2021-05-13 at 10:01 +0200, Martin Liška wrote:
> PING^1
Sorry I missed this earlier.
> On 4/22/21 1:11 PM, Martin Liška wrote:
> > Right now, dwz return code is 0 or a small integer value (<= 3)
> > for situations like:
> >
> > - dwz: Too few files for multifile optimization
> > - dwz: Multi-file optimization not allowed for different pointer sizes or endianity
> >
> > These are not fatal errors and the script should continue. On the other
> > hand abort or segfault error values should cause failure of the script.
> >
> > Let's reserve values 1-16 for a recoverable dwz exit codes.
With "recoverable" you mean that dwz did do compression, but could not
deliver optimal compression?
It would be good to have an ack from the dwz developers that 1 to 16
are "recoverable" errors (I added dwz@sourceware.org to CC).
Would it be possible to tweak the find-debuginfo.sh script to avoid
them? e.g. Could we see how many arguments we have so that we only use
-m when there are 1+ debug files? And/Or detect debug files using
different endianess and ptr sizes so they are processed in different
batches?
Ideally an error code from dwz means something went terribly wrong and
we abort find-debuginfo.sh. IMHO.
Cheers,
Mark
next prev parent reply other threads:[~2021-05-13 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 11:11 Martin Liška
2021-05-13 8:01 ` Martin Liška
2021-05-13 14:07 ` Mark Wielaard [this message]
2021-05-14 10:46 ` Martin Liška
2021-05-16 20:14 ` Mark Wielaard
2021-05-17 10:06 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cfabb5c75508dc7dc419caa7c0e935ebc241bb3.camel@klomp.org \
--to=mark@klomp.org \
--cc=debugedit@sourceware.org \
--cc=dwz@sourceware.org \
--cc=mliska@suse.cz \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).