From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 6245D39450CF; Fri, 14 May 2021 10:46:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6245D39450CF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6448CABF6; Fri, 14 May 2021 10:46:16 +0000 (UTC) Subject: Re: [PATCH] Fail if dwz fails. To: Mark Wielaard , debugedit@sourceware.org Cc: dwz@sourceware.org, Tom de Vries References: <0c4f9c78-ee2b-fb6f-a0f9-20c3731bfa0e@suse.cz> <0cfabb5c75508dc7dc419caa7c0e935ebc241bb3.camel@klomp.org> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <153645a1-cdd7-e5cc-a392-e63ad3d44433@suse.cz> Date: Fri, 14 May 2021 12:46:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <0cfabb5c75508dc7dc419caa7c0e935ebc241bb3.camel@klomp.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: debugedit@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: debugedit development mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 10:46:18 -0000 On 5/13/21 4:07 PM, Mark Wielaard wrote: > Hi Martin, > > On Thu, 2021-05-13 at 10:01 +0200, Martin Liška wrote: >> PING^1 > > Sorry I missed this earlier. > >> On 4/22/21 1:11 PM, Martin Liška wrote: >>> Right now, dwz return code is 0 or a small integer value (<= 3) >>> for situations like: >>> >>> - dwz: Too few files for multifile optimization >>> - dwz: Multi-file optimization not allowed for different pointer sizes or endianity >>> >>> These are not fatal errors and the script should continue. On the other >>> hand abort or segfault error values should cause failure of the script. >>> >>> Let's reserve values 1-16 for a recoverable dwz exit codes. > > With "recoverable" you mean that dwz did do compression, but could not > deliver optimal compression? No, I speak about cases, where compression cannot be done (different endianess, ptr sizes, not beneficial, any other reason). > > It would be good to have an ack from the dwz developers that 1 to 16 > are "recoverable" errors (I added dwz@sourceware.org to CC). Yes. That's why I CCed Tom. > > Would it be possible to tweak the find-debuginfo.sh script to avoid > them? e.g. Could we see how many arguments we have so that we only use > -m when there are 1+ debug files? And/Or detect debug files using > different endianess and ptr sizes so they are processed in different > batches? No, I would leave it to dwz. There may be other reasons. > > Ideally an error code from dwz means something went terribly wrong and > we abort find-debuginfo.sh. IMHO. I would allow the mentioned "soft" error codes. Martin > > Cheers, > > Mark >