public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Vitaly Chikunov <vt@altlinux.org>, debugedit@sourceware.org
Subject: Re: [PATCH] tests: fix for toolchains producing compressed debug sections
Date: Sun, 28 Mar 2021 16:01:23 +0200	[thread overview]
Message-ID: <20210328140123.GR2685@wildebeest.org> (raw)
In-Reply-To: <20210328004608.GB20963@altlinux.org>

Hi Dmitry,

On Sun, Mar 28, 2021 at 03:46:09AM +0300, Dmitry V. Levin wrote:
> On Fri, Mar 26, 2021 at 12:12:59AM +0100, Mark Wielaard wrote:
> > Sorry, I didn't know you were already working on this.  Your version
> > does everything in debugedit.at which is nicely contained. But I think
> > doing it as configure checks might help if we need them somewhere
> > else. But you version tests the actual gcc command used in the
> > test. We probably need to use CC instead in the tests, so it equals
> > the build/target compiler.
> > 
> > What do you think of the attached patch?
> 
> It looks good, thanks.

Thanks, pushed.

> Those who want to use different CC/CFLAGS or
> LD/LDFLAGS would be able to edit tests/atlocal.in themselves.

If people regularly need to do that, then we can also adopt
TEST_CC/CFLAGS TEST_LD/LDFLAGS (which default to CC/LD/etc.) Please
yell and scream if that would be helpful to your test environment.

Cheers,

Mark

      reply	other threads:[~2021-03-28 14:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 20:00 Dmitry V. Levin
2021-03-23 14:20 ` Mark Wielaard
2021-03-23 14:28   ` Dmitry V. Levin
2021-03-23 15:05     ` Mark Wielaard
2021-03-24 23:45       ` Dmitry V. Levin
2021-03-25 23:12         ` Mark Wielaard
2021-03-28  0:46           ` Dmitry V. Levin
2021-03-28 14:01             ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210328140123.GR2685@wildebeest.org \
    --to=mark@klomp.org \
    --cc=debugedit@sourceware.org \
    --cc=ldv@altlinux.org \
    --cc=vt@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).