From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id ED6AB385703C for ; Sun, 28 Mar 2021 14:02:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ED6AB385703C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 40BF5302FB96; Sun, 28 Mar 2021 16:02:40 +0200 (CEST) Received: by librem (Postfix, from userid 1000) id 39434C287D; Sun, 28 Mar 2021 16:01:23 +0200 (CEST) Date: Sun, 28 Mar 2021 16:01:23 +0200 From: Mark Wielaard To: "Dmitry V. Levin" Cc: Vitaly Chikunov , debugedit@sourceware.org Subject: Re: [PATCH] tests: fix for toolchains producing compressed debug sections Message-ID: <20210328140123.GR2685@wildebeest.org> References: <20210322200000.GA3531@altlinux.org> <20210323142852.GA15238@altlinux.org> <6d7325b924aa56456f19316f091c76bb34252991.camel@klomp.org> <20210324234548.GA5335@altlinux.org> <20210325231259.GJ2685@wildebeest.org> <20210328004608.GB20963@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210328004608.GB20963@altlinux.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: debugedit@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: debugedit development mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2021 14:02:43 -0000 Hi Dmitry, On Sun, Mar 28, 2021 at 03:46:09AM +0300, Dmitry V. Levin wrote: > On Fri, Mar 26, 2021 at 12:12:59AM +0100, Mark Wielaard wrote: > > Sorry, I didn't know you were already working on this. Your version > > does everything in debugedit.at which is nicely contained. But I think > > doing it as configure checks might help if we need them somewhere > > else. But you version tests the actual gcc command used in the > > test. We probably need to use CC instead in the tests, so it equals > > the build/target compiler. > > > > What do you think of the attached patch? > > It looks good, thanks. Thanks, pushed. > Those who want to use different CC/CFLAGS or > LD/LDFLAGS would be able to edit tests/atlocal.in themselves. If people regularly need to do that, then we can also adopt TEST_CC/CFLAGS TEST_LD/LDFLAGS (which default to CC/LD/etc.) Please yell and scream if that would be helpful to your test environment. Cheers, Mark