public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: debugedit@sourceware.org, "Ivan A. Melnikov" <iv@altlinux.org>
Subject: Re: [PATCH] debugedit: add MIPS support
Date: Sat, 3 Apr 2021 01:03:09 +0200	[thread overview]
Message-ID: <20210402230309.GW2685@wildebeest.org> (raw)
In-Reply-To: <20210402080000.GA13000@altlinux.org>

Hi Dmitry, Hi Ivan,

On Fri, Apr 02, 2021 at 08:00:00AM +0000, Dmitry V. Levin wrote:
> From: "Ivan A. Melnikov" <iv@altlinux.org>
> Date: Fri, 13 Nov 2020 15:51:08 +0400
> 
> According to the specification[1], all MIPS .debug_* sections are
> marked with ELF type SHT_MIPS_DWARF.  The format of the section
> data stays the same, so we have can handle e.g. .debug_info
> section as we used to.
> 
> As SHT_MIPS_DWARF is from processor-specific range, we have to check
> that we're actually dealing with MIPS ELF file before handling such
> sections.
> 
> [1] MIPS Extensions to DWARF Version 2.0. -- Silicon Graphics
>     Computer Systems, rev 1.17, 29 Aug 2001
> 
> Refs: https://bugzilla.altlinux.org/39284
> Signed-off-by: Ivan A. Melnikov <iv@altlinux.org>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>

This looks correct. I have pushed it to main.  I don't have a MIPS
setup to check, but don't you also need some R_MIPS value for
setup_relbuf?

Thanks,

Mark

  reply	other threads:[~2021-04-02 23:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02  8:00 Dmitry V. Levin
2021-04-02 23:03 ` Mark Wielaard [this message]
2021-04-09 10:17   ` Ivan A. Melnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210402230309.GW2685@wildebeest.org \
    --to=mark@klomp.org \
    --cc=debugedit@sourceware.org \
    --cc=iv@altlinux.org \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).