From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id EE6A9385781B for ; Fri, 2 Apr 2021 23:04:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EE6A9385781B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8D9F33032F92; Sat, 3 Apr 2021 01:04:27 +0200 (CEST) Received: by librem (Postfix, from userid 1000) id 2054DC34FD; Sat, 3 Apr 2021 01:03:09 +0200 (CEST) Date: Sat, 3 Apr 2021 01:03:09 +0200 From: Mark Wielaard To: "Dmitry V. Levin" Cc: debugedit@sourceware.org, "Ivan A. Melnikov" Subject: Re: [PATCH] debugedit: add MIPS support Message-ID: <20210402230309.GW2685@wildebeest.org> References: <20210402080000.GA13000@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210402080000.GA13000@altlinux.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: debugedit@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: debugedit development mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2021 23:04:31 -0000 Hi Dmitry, Hi Ivan, On Fri, Apr 02, 2021 at 08:00:00AM +0000, Dmitry V. Levin wrote: > From: "Ivan A. Melnikov" > Date: Fri, 13 Nov 2020 15:51:08 +0400 > > According to the specification[1], all MIPS .debug_* sections are > marked with ELF type SHT_MIPS_DWARF. The format of the section > data stays the same, so we have can handle e.g. .debug_info > section as we used to. > > As SHT_MIPS_DWARF is from processor-specific range, we have to check > that we're actually dealing with MIPS ELF file before handling such > sections. > > [1] MIPS Extensions to DWARF Version 2.0. -- Silicon Graphics > Computer Systems, rev 1.17, 29 Aug 2001 > > Refs: https://bugzilla.altlinux.org/39284 > Signed-off-by: Ivan A. Melnikov > Signed-off-by: Dmitry V. Levin This looks correct. I have pushed it to main. I don't have a MIPS setup to check, but don't you also need some R_MIPS value for setup_relbuf? Thanks, Mark