From: Mark Wielaard <mark@klomp.org>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: debugedit@sourceware.org
Subject: Re: [PATCH] debugedit: Fix 'Unhandled relocation 0 in .debug_info section' on e2k
Date: Wed, 14 Apr 2021 19:24:06 +0200 [thread overview]
Message-ID: <20210414172406.GV3953@wildebeest.org> (raw)
In-Reply-To: <20210414163908.1661484-1-vt@altlinux.org>
Hi Vitaly,
On Wed, Apr 14, 2021 at 07:39:08PM +0300, Vitaly Chikunov wrote:
> Fix handling of Elbrus ELF relocatables:
>
> /usr/lib/rpm/debugedit: ./lib/modules/5.4.58-elbrus-def-alt1/misc/xt_so.ko: Unhandled relocation 0 in .debug_info section
I cannot test this myself, and I see glibc elf.h doesn't contain any
of the Elbrus relocations (but does know about EM_MCST_ELBRUS). But it
looks obviously correct and won't affect builds on other
systems. Pushed to main.
Thanks,
Mark
> Reported-by: Michael Shigorin <mike@altlinux.org>
> Tested-by: Andrey Savchenko <bircoph@altlinux.org>
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> ---
> tools/debugedit.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/debugedit.c b/tools/debugedit.c
> index 917c59b..4527a08 100644
> --- a/tools/debugedit.c
> +++ b/tools/debugedit.c
> @@ -617,6 +617,12 @@ setup_relbuf (DSO *dso, debug_section *sec, int *reltype)
> goto fail;
> break;
> #endif
> +#if defined(EM_MCST_ELBRUS) && defined(R_E2K_32_ABS)
> + case EM_MCST_ELBRUS:
> + if (rtype != R_E2K_32_ABS)
> + goto fail;
> + break;
> +#endif
> default:
> fail:
> error (1, 0, "%s: Unhandled relocation %d in %s section",
> --
> 2.11.0
>
prev parent reply other threads:[~2021-04-14 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 16:39 Vitaly Chikunov
2021-04-14 17:24 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414172406.GV3953@wildebeest.org \
--to=mark@klomp.org \
--cc=debugedit@sourceware.org \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).