From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id D1885397300B for ; Wed, 14 Apr 2021 17:25:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D1885397300B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 86FAE30291BE; Wed, 14 Apr 2021 19:25:25 +0200 (CEST) Received: by librem (Postfix, from userid 1000) id 8D6D0C2799; Wed, 14 Apr 2021 19:24:06 +0200 (CEST) Date: Wed, 14 Apr 2021 19:24:06 +0200 From: Mark Wielaard To: Vitaly Chikunov Cc: debugedit@sourceware.org Subject: Re: [PATCH] debugedit: Fix 'Unhandled relocation 0 in .debug_info section' on e2k Message-ID: <20210414172406.GV3953@wildebeest.org> References: <20210414163908.1661484-1-vt@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414163908.1661484-1-vt@altlinux.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: debugedit@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: debugedit development mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2021 17:25:29 -0000 Hi Vitaly, On Wed, Apr 14, 2021 at 07:39:08PM +0300, Vitaly Chikunov wrote: > Fix handling of Elbrus ELF relocatables: > > /usr/lib/rpm/debugedit: ./lib/modules/5.4.58-elbrus-def-alt1/misc/xt_so.ko: Unhandled relocation 0 in .debug_info section I cannot test this myself, and I see glibc elf.h doesn't contain any of the Elbrus relocations (but does know about EM_MCST_ELBRUS). But it looks obviously correct and won't affect builds on other systems. Pushed to main. Thanks, Mark > Reported-by: Michael Shigorin > Tested-by: Andrey Savchenko > Signed-off-by: Vitaly Chikunov > --- > tools/debugedit.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/debugedit.c b/tools/debugedit.c > index 917c59b..4527a08 100644 > --- a/tools/debugedit.c > +++ b/tools/debugedit.c > @@ -617,6 +617,12 @@ setup_relbuf (DSO *dso, debug_section *sec, int *reltype) > goto fail; > break; > #endif > +#if defined(EM_MCST_ELBRUS) && defined(R_E2K_32_ABS) > + case EM_MCST_ELBRUS: > + if (rtype != R_E2K_32_ABS) > + goto fail; > + break; > +#endif > default: > fail: > error (1, 0, "%s: Unhandled relocation %d in %s section", > -- > 2.11.0 >