From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ldv@altlinux.org>
Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57])
 by sourceware.org (Postfix) with ESMTP id CB1FC385040D
 for <debugedit@sourceware.org>; Fri, 30 Apr 2021 12:19:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CB1FC385040D
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=altlinux.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ldv@altlinux.org
Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14])
 by vmicros1.altlinux.org (Postfix) with ESMTP id 588A772C8B0;
 Fri, 30 Apr 2021 15:19:08 +0300 (MSK)
Received: by mua.local.altlinux.org (Postfix, from userid 508)
 id 4EB1C7CF715; Fri, 30 Apr 2021 15:19:08 +0300 (MSK)
Date: Fri, 30 Apr 2021 15:19:08 +0300
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Mark Wielaard <mark@klomp.org>
Cc: debugedit@sourceware.org
Subject: Re: [PATCH] find-debuginfo.sh: Add --help, --version and man page.
Message-ID: <20210430121907.GF5477@altlinux.org>
References: <20210429224604.9906-1-mark@klomp.org>
 <20210429230630.GC29311@altlinux.org>
 <93393113c5d29d9861ef6ee5105062cfb3447b23.camel@klomp.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <93393113c5d29d9861ef6ee5105062cfb3447b23.camel@klomp.org>
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: debugedit@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: debugedit development mailing list <debugedit.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/debugedit>,
 <mailto:debugedit-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/debugedit/>
List-Post: <mailto:debugedit@sourceware.org>
List-Help: <mailto:debugedit-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/debugedit>,
 <mailto:debugedit-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2021 12:19:10 -0000

Hi Mark,

On Fri, Apr 30, 2021 at 02:10:14PM +0200, Mark Wielaard wrote:
> Hi Dmitry,
> 
> On Fri, 2021-04-30 at 02:06 +0300, Dmitry V. Levin wrote:
> > I suggest to use "cat" instead of multiple echoes, e.g.
> > 
> >   cat <<-'EOF'
> > 	Usage: find-debuginfo.sh [OPTION]... [builddir]
> > 	automagically generates debug info and file lists
> > 
> > 	Options:
> > 	[...]
> > 	--unique-debug-src-base "%{name}-%{VERSION}-
> > %{RELEASE}.%{_arch}")
> > 
> > 	All file names in switches are relative to builddir ('.' if not
> > given).
> >   EOF
> 
> Yes, that is obviously much nicer.

It would look even nicer if EOF was quoted, e.g. 'EOF'.
>From bash manual page:
"If any part of word is quoted, the delimiter is the result of quote
removal on word, and the lines in the here-document are not expanded."

[...]
> +--unique-debug-src-base \"%{name}-%{VERSION}-%{RELEASE}.%{_arch}\")

I suggest to quote EOF once and forget about quoting anything in the whole
text.


-- 
ldv