From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id B33393858D20 for ; Thu, 26 Jan 2023 23:14:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B33393858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id DD4A8302BBEC; Fri, 27 Jan 2023 00:14:35 +0100 (CET) Date: Fri, 27 Jan 2023 00:14:35 +0100 From: Mark Wielaard To: Kalev Lember Cc: debugedit@sourceware.org Subject: Re: [PATCH] find-debuginfo: Pass -j down to dwz Message-ID: <20230126231435.GA21676@gnu.wildebeest.org> References: <20230119160318.3868439-1-klember@redhat.com> <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3031.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kalev, On Thu, Jan 26, 2023 at 04:57:18PM +0100, Kalev Lember wrote: > > I agree with Panu that a configure check would be nice to make sure the > > installed dwz does support -j. Would the attached patch work for you? > > > > That looks perfect to me. Thanks a lot! Pushed as: commit 5b23e464528ef988cfcd0a87b3ec8db0520db867 Author: Kalev Lember Date: Thu Jan 19 17:03:18 2023 +0100 find-debuginfo: Pass -j down to dwz Now that dwz 0.15 supports parallel jobs, add a way to control it from here. find-debuginfo already has a -j parameter so we can just extend it and pass the value down to dwz as well. This should fix building large packages on memory constrained builders, such as webkitgtk on s390x in Fedora koji build system, where we can now use the -j option to tune down parallelism to avoid running out of memory during dwz run. Add a configure check to make sure the installed dwz supports the -j option. Signed-off-by: Kalev Lember Signed-off-by: Mark Wielaard > Can you also apply it to the rawhide package, please? That way I can > confirm if it actually works on actual koji builders and see if we can get > webkitgtk building right. I will, but as you might have seen the rawhide buildbot just failed. All others seem green, so it probably is the new gcc or some compiler flag changes in fedora rawhide: https://builder.sourceware.org/buildbot/#/changes/17730 As soon as I figure out how to get the testsuite green on rawhide I'll also push this patch there. Cheers, Mark