From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id DA15F3858D1E for ; Sat, 25 Mar 2023 11:30:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA15F3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id C4DEE72C8D3 for ; Sat, 25 Mar 2023 14:30:43 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id BB80F7CCB48; Sat, 25 Mar 2023 14:30:43 +0300 (IDT) Date: Sat, 25 Mar 2023 14:30:43 +0300 From: "Dmitry V. Levin" To: debugedit@sourceware.org Subject: Re: [PATCH 1/3] debugedit: skip .debug_types tests if compiler doesn't generate section Message-ID: <20230325113043.GA19701@altlinux.org> References: <20230324235807.2335399-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230324235807.2335399-1-mark@klomp.org> X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Mar 25, 2023 at 12:58:05AM +0100, Mark Wielaard wrote: > Some compilers don't generate a .debug_types section even when compiling > with -fdebug-types-section. Skip testing the .debug_types tests in that > case. > > Signed-off-by: Mark Wielaard > --- > tests/debugedit.at | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/debugedit.at b/tests/debugedit.at > index 725e68e..0601127 100644 > --- a/tests/debugedit.at > +++ b/tests/debugedit.at > @@ -364,6 +364,7 @@ AT_CLEANUP > AT_SETUP([debugedit .debug_types objects]) > AT_KEYWORDS([debugtypes] [debugedit]) > DEBUGEDIT_SETUP([-fdebug-types-section -gdwarf-4]) > +AT_SKIP_IF([! $READELF -S ./foo.o ./subdir_bar/bar.o ./baz.o | grep -q '.debug_types']) Should it rather be grep -F -q? -- ldv