From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id D62B43858D35 for ; Thu, 29 Jun 2023 14:13:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D62B43858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id E5CAB3006CF5; Thu, 29 Jun 2023 16:13:49 +0200 (CEST) Date: Thu, 29 Jun 2023 16:13:49 +0200 From: Mark Wielaard To: Denys Vlasenko Cc: debugedit@sourceware.org Subject: Re: [PATCH] find-debuginfo: unless -q -q, print messages what big steps we are at Message-ID: <20230629141349.GA13707@gnu.wildebeest.org> References: <20230622133103.11551-1-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230622133103.11551-1-dvlasenk@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Denys, On Thu, Jun 22, 2023 at 03:31:03PM +0200, Denys Vlasenko wrote: > For a reader of rpmbuild's log, it's rather unclear what find-debuginfo > is doing. It used to be too verbose, "extracting debug info from FILE" > for every file, and while this can be suppressed now, we still end up > with something semi-mysterious like this: > > ... > extracting debug info from /builddir/build/BUILDROOT/xyz > gdb-add-index: No index was created for /builddir/build/BUILDROOT/xyz > gdb-add-index: [Was there no debuginfo? Was there already an index?] > symlinked /usr/lib/debug/usr/lib64/libcpupower.so.0.0.1.debug to /usr/lib/debug/usr/lib64/libcpupower.so.debug > symlinked /usr/lib/debug/usr/lib64/libcpupower.so.0.0.1.debug to /usr/lib/debug/usr/lib64/libcpupower.so.0.debug > cpio: binutils-2.30/bfd: Cannot stat: No such file or directory > cpio: binutils-2.30/bfd/aout-target.h: Cannot stat: No such file or directory > cpio: binutils-2.30/bfd/aoutx.h: Cannot stat: No such file or directory > cpio: binutils-2.30/bfd/archive.c: Cannot stat: No such file or directory > cpio: binutils-2.30/bfd/archive64.c: Cannot stat: No such file or directory > ... > 775655 blocks > + /usr/lib/rpm/check-buildroot > + /usr/lib/rpm/redhat/brp-ldconfig > ... > > The reader is left confused. "What these cpio errors are about? > Why those sources are not found?" (Well, because not every source > name extracted by 'debugedit -l' has to exist, but this requires > considerable digging aroung to understand). > > We can give a few messages explaining what general steps we go through: > > Extracting debug info from N files > DWARF-compressing N files > Creating .debug symlinks for symlinks to ELF files > Copying sources found by 'debugedit -l' > > This is also useful to get a feeling which steps are time consuming. > Kernel builds often need to investigate this aspect. To help a bit more, > add "find-debuginfo: starting" and "find-debuginfo: done" messages too. > > This patch adds these messages. > > Two -q -q options suppress these messages too. I like this idea, but I am wondering if instead of -q -q we should have a -v,--verbose flag for the very verbose output. Then this explanary output could be the default. And -q,--quiet would suppress even those message. Cheers, Mark