From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 68D093858D20 for ; Wed, 15 May 2024 22:02:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68D093858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68D093858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715810538; cv=none; b=lMfrmUVXi01h1+K9URTxXq2BzYnTmRP6Whj18haZgFzFQBOhbz67jzL6ZmWuBKnxmJF70+w04E1ifr//A4NOif7CFgQ+5zEA8t7S14nHGEgvzWV70BxJ0qcpgo6gSjGfF8PfMA7ZOqZTK0F8PfXr1dM2oLsKGrDx7tDzaoWNLpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715810538; c=relaxed/simple; bh=RsBCXrUUNPUFIwR/hy3wI2c3UUWFVmX4udOv3G9kunw=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=iw3fSrSR8xvMCTAP/FZ/tS8SNv5uMpfMTDUe1lOzdOWDCnQvqpB8O864vy2l7rMaFQzX93z87fujWjBEV5lGdMd3DegiEO2pmD99KvS6bgCgPlLaL0pDgdVyT9ZkP8JHP8VLOPDN+JPgknNc7yHCK9vcnYTWLEU2R+5Xl85glw0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from csb.redhat.com (deer0x03.wildebeest.org [172.31.17.133]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7B62D3000590; Thu, 16 May 2024 00:02:16 +0200 (CEST) Received: by csb.redhat.com (Postfix, from userid 10916) id 5D07ACEEED; Thu, 16 May 2024 00:02:16 +0200 (CEST) From: Mark Wielaard To: debugedit@sourceware.org Cc: Mark Wielaard Subject: [PATCH] debug_str_offsets header version and padding are 2 bytes, not 4 bytes Date: Thu, 16 May 2024 00:02:08 +0200 Message-Id: <20240515220208.1129397-1-mark@klomp.org> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Reading too much bytes for the header made debugedit skip the first actual string offsets table entry. Signed-off-by: Mark Wielaard --- tools/debugedit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/debugedit.c b/tools/debugedit.c index 1a46c13dee47..cbfe70970743 100644 --- a/tools/debugedit.c +++ b/tools/debugedit.c @@ -2724,10 +2724,10 @@ update_str_offsets (DSO *dso) if (unit_length == 0xffffffff || endp - ptr < unit_length) break; unsigned char *endidxp = ptr + unit_length; - uint32_t version = read_32 (ptr); + uint32_t version = read_16 (ptr); if (version != 5) break; - uint32_t padding = read_32 (ptr); + uint32_t padding = read_16 (ptr); if (padding != 0) break; -- 2.39.3