public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: debugedit@sourceware.org
Subject: Re: [PATCH] Make relocation reading explicit
Date: Sun, 19 May 2024 15:23:26 +0200	[thread overview]
Message-ID: <20240519132326.GE25437@gnu.wildebeest.org> (raw)
In-Reply-To: <20240515204012.1120994-1-mark@klomp.org>

Hi,

On Wed, May 15, 2024 at 10:40:12PM +0200, Mark Wielaard wrote:
> Relocation handling used to be linear per section. But since handling
> .debug_str_offsets (which can have relocations itself) we had to
> "reset" the relocation handling when switching between reading
> sections. This caused a lnear search from the start of the relocation
> table each time section reading was switched. Since this was slow
> do_read_32_relocated needed to be optimized using a binary search
> (commit fbad879eb).
> 
> Since we do a binary search now, resetting the relocation
> datastructure isn't really needed. It is also a little confusing and
> fragile. Rewrite the relocation code so it works per section and
> doesn't need "switching".
> 
> Make the relocation related data structures part of struct
> debug_section. And change do_read_32_relocated to take a struct
> debug_section. This way we make explicit from which section we are
> reading.

I pushed this to main.

Cheers,

Mark

      reply	other threads:[~2024-05-19 13:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 20:40 Mark Wielaard
2024-05-19 13:23 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240519132326.GE25437@gnu.wildebeest.org \
    --to=mark@klomp.org \
    --cc=debugedit@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).