From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BAED13858C62 for ; Fri, 30 Jun 2023 18:51:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAED13858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688151099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fc8khO7/DpUtwKUaAmZyH/OauuDLCg1kqurE/qsNktw=; b=IuXbO30HWzvMEYzPmzJyUdWQXC9MNvOONOsVUdmwq14IAeR0TZvodkSnt6mvDID8eRTYP0 JVJS9tQb8n6pQkL8j43bN4D6rAkykd9V21D3aNjubw498p6EWlm6ruO48pOwYrRkOFn46e Z7nxpuWY2C6uHci6c1ZqE51CjOL9vrs= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-114-Vci6E5Q-NdGbtGhJthZH8A-1; Fri, 30 Jun 2023 14:51:37 -0400 X-MC-Unique: Vci6E5Q-NdGbtGhJthZH8A-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-9874fbf5c95so250026766b.1 for ; Fri, 30 Jun 2023 11:51:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688151096; x=1690743096; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fc8khO7/DpUtwKUaAmZyH/OauuDLCg1kqurE/qsNktw=; b=Wp5jA1yW00HHk23UPMVM4gou7+9XvlMwTQN6wKzC9miHGMyP48Ja/sMHVsYjvlN7Vm 6opg3LP5JdIdqoK+N18gm3RFSY4jlcEMMqsakWmt+p+mmKUcO9ts2Ffwo8VdlLkZMeOi O+XimJ0pPPpzjJWUxWxNQ3+INRgTr7VRU2FBIfenI2+QGY3Hl4nPBgWPWJlJwAyq+eHM 81jLN1ry5aQHhmY2qdK4LEME0QRYoft3fLvHq34/NZq90uLMPp6qMFxZH0YUHCmG9RK8 83bNkSHNuRFGt72pwKeLEetbv+ujpZ+MGuSxovn/IsxCI9OOXN/CRgkmrU/h2ihaSHsZ +erw== X-Gm-Message-State: AC+VfDzHNrmOOHxcMt/rfe8gm4Wi0t/MSFTuGRClwdbk2b/xRMxLELgF kSe18edAEo3xcpWKoezKwXO2HzhEnaI7AhvSG9X4ea5Dt9cYL6NCFkn7gZRIzZq4obOnGixReuz 5o+TXDIw0ejKBkBLWap4= X-Received: by 2002:a17:907:9815:b0:96f:94f1:b0a5 with SMTP id ji21-20020a170907981500b0096f94f1b0a5mr8511670ejc.8.1688151096713; Fri, 30 Jun 2023 11:51:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4bmeZ3xZbecjqGaGRwO3xSgTspWDXo1RMsrse+NPnoQmZ7zkoiMWibFB4A0dNZ077EEmCbiQ== X-Received: by 2002:a17:907:9815:b0:96f:94f1:b0a5 with SMTP id ji21-20020a170907981500b0096f94f1b0a5mr8511661ejc.8.1688151096475; Fri, 30 Jun 2023 11:51:36 -0700 (PDT) Received: from [10.43.17.4] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id jj25-20020a170907985900b00992b1c93279sm2024227ejc.110.2023.06.30.11.51.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jun 2023 11:51:36 -0700 (PDT) Message-ID: <2ebe27f4-2522-6257-7a38-f6b5adb00e68@redhat.com> Date: Fri, 30 Jun 2023 20:51:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] find-debuginfo: unless -q -q, print messages what big steps we are at To: Mark Wielaard Cc: debugedit@sourceware.org, Prarit Bhargava References: <20230622133103.11551-1-dvlasenk@redhat.com> <20230629141349.GA13707@gnu.wildebeest.org> <025ec8a4f5e26a4f0f40b90776c9033b45299396.camel@klomp.org> From: Denys Vlasenko In-Reply-To: <025ec8a4f5e26a4f0f40b90776c9033b45299396.camel@klomp.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/30/23 15:25, Mark Wielaard wrote: > Hi Denys, > > On Thu, 2023-06-29 at 16:13 +0200, Mark Wielaard wrote: >>> We can give a few messages explaining what general steps we go through: >>> >>> Extracting debug info from N files >>> DWARF-compressing N files >>> Creating .debug symlinks for symlinks to ELF files >>> Copying sources found by 'debugedit -l' >>> >>> This is also useful to get a feeling which steps are time consuming. >>> Kernel builds often need to investigate this aspect. To help a bit more, >>> add "find-debuginfo: starting" and "find-debuginfo: done" messages too. >>> >>> This patch adds these messages. >>> >>> Two -q -q options suppress these messages too. >> >> I like this idea, but I am wondering if instead of -q -q we should >> have a -v,--verbose flag for the very verbose output. Then this >> explanary output could be the default. And -q,--quiet would suppress >> even those message. > > So this is what I was thinking. What do you think? > https://code.wildebeest.org/git/user/mjw/debugedit/commit/?h=verbose Looks good. We will be able to revert "Suppress 'extracting debug info' noise in build log" +%if 0%{?fedora} +%global _find_debuginfo_opts -r -q +%else %global _find_debuginfo_opts -r +%endif change in our kernel specfile (always good to have fewer special cases) and still have what that change intended: not-very-verbose find-debuginfo output.