From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 2AADC3858407 for ; Thu, 26 Jan 2023 15:02:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2AADC3858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 17885302BBEC; Thu, 26 Jan 2023 16:02:50 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id 5CD2C340196; Thu, 26 Jan 2023 16:02:50 +0100 (CET) Message-ID: <345248abd55a2ebc9aa89f3d87f9ce0405b8caa5.camel@klomp.org> Subject: Re: [PATCH] scripts/find-debuginfo.in: Add --no-per-file-msg From: Mark Wielaard To: Prarit Bhargava , debugedit@sourceware.org Date: Thu, 26 Jan 2023 16:02:50 +0100 In-Reply-To: <20230123202737.3632441-1-prarit@redhat.com> References: <20230123202737.3632441-1-prarit@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Prarit, On Mon, 2023-01-23 at 15:27 -0500, Prarit Bhargava wrote: > Projects with a large number of compiled files end up with a large number > of 'extracting debug info from' messages in the build log. In the case o= f > the Fedora kernel these messages account for 8504 lines in the log, or 61= % > of the entire log [1]. >=20 > Removing these lines make the log easier to view and comprehend for some > projects, however, not all projects will want to silence these messages s= o > suppressing them must be optional. > > Add a --no-per-file-msg which allows users to disable the per file > scanning message and in its place output a single general message in the > log. I appreciate the idea, but I think it is better to have a more standard -q, --quiet option that simply suppresses all none error/warnings.=C2=A0 find-debuginfo already has too many specialized options IMHO. Besides this "per file" output that is just these three extra output lines: echo "symlinked /usr/lib/debug$t to /usr/lib/debug${f}.debug" echo "hard linked $link to $debugfn" echo "original debug info size: ${size_before}kB, size after compression: ${size_after}kB" (For that last one, you can then also hide the size_before and size_after calculations behind $quiet &&) Cheers, Mark