public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: debugedit@sourceware.org
Subject: Re: [COMMITTED] automake: Add std-options to check --version and --help work as intended.
Date: Wed, 05 May 2021 22:05:03 +0200	[thread overview]
Message-ID: <5b190b6edb6b7b79f136f48643e23f685ef16b8a.camel@klomp.org> (raw)
In-Reply-To: <20210505193233.20312-1-mark@klomp.org>

Hi,

On Wed, 2021-05-05 at 21:32 +0200, Mark Wielaard wrote:
> Now that we rely on --version and --help to generate documentation make
> sure that make distcheck checks those standard options work correctly.
> Also adjust find-debuginfo.sh[.1] rules slightly to make sure they the
> scripts are also checked (bin_SCRIPTS are, but dist_bin_SCRIPTS aren't).
> 
> 	* configure.ac (AM_INIT_AUTOMAKE): Add std-options.
> 	* Makefile.am (dist_bin_SCRIPTS): Change into...
> 	(bin_SCRIPTS): ... this, using top_srcdir.
> 	(TOP_CONFIGURE_AC): New variable, with comment explaining when
> 	.1 man pages are (re)generated.
> 	(debugedit.1): Use TOP_CONFIGURE_AC as dependency.
> 	(sepdebugcrcfix.1): Likewise.
> 	(find-debuginfo.sh.1): Likewise and depend on top_srcdir script.

Unfortunately this didn't work everywhere, newer automake don't add
scripts/find-debuginfo.sh to the dist. So I had to push a fixup:

commit e3ac91ca17e0196081bd350db3c8080cb531d3f2 (HEAD -> main)
Author: Mark Wielaard <mark@klomp.org>
Date:   Wed May 5 22:00:08 2021 +0200

    Makefile.am: Add scripts/find-debuginfo.sh to EXTRA_DIST
    
    Signed-off-by: Mark Wielaard <mark@klomp.org>

diff --git a/Makefile.am b/Makefile.am
index 5bf003b..ef972e8 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -67,4 +67,4 @@ noinst_HEADERS= tools/ansidecl.h \
                tools/md5.h \
                tools/sha1.h
 
-EXTRA_DIST = README COPYING COPYING3 COPYING.LIB
+EXTRA_DIST = README COPYING COPYING3 COPYING.LIB scripts/find-debuginfo.sh

This wasn't helped by some of the buildbot workers not yet having
help2man installed (most have now, just the s390x, and ppc64/ppc64le
setups don't have it yet).

Cheers,

Mark

      reply	other threads:[~2021-05-05 20:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 19:32 Mark Wielaard
2021-05-05 20:05 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b190b6edb6b7b79f136f48643e23f685ef16b8a.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=debugedit@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).