public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>, debugedit@sourceware.org
Subject: Re: [PATCH 2/2] debugedit: consistently use error() instead of fprintf(stderr)
Date: Thu, 29 Apr 2021 14:59:49 +0200	[thread overview]
Message-ID: <93e810d766effed80b1e6ea391837844756e4730.camel@klomp.org> (raw)
In-Reply-To: <20210426200000.GB12328@altlinux.org>

Hi Dmitry,

On Mon, 2021-04-26 at 20:00 +0000, Dmitry V. Levin wrote:
> The error() function is already used in debugedit for printing some
> of diagnostic messages, extend this practice to all such messages.
> The user-visible side of this change is that all diagnostic messages
> are now consistently prefixed.
> 
> * tools/debugedit.c (edit_attributes, handle_build_id, main): Replace
> fprintf(stderr) with error().

Thanks, this makes the error handling more consistent.

Pushed,

Mark

      reply	other threads:[~2021-04-29 12:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 20:00 Dmitry V. Levin
2021-04-29 12:59 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93e810d766effed80b1e6ea391837844756e4730.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=debugedit@sourceware.org \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).