From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E76483858D28 for ; Thu, 26 Jan 2023 15:57:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E76483858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674748652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rJEpaYXarlCa5mY2mox+K2PW+6++LhpOykQ3c/hj8Bg=; b=Nf8zZD05DbOl3/mXbsT3fwzmU9SKaAB07ei4Vh22mPXkH8nT9Lv5ZT1a2PP1TryqTeQf0A S1VuambFv+vHtKMmjwegsbbWmYZazRkp7Q9NJeP2g332nzyTAvPmq75V6Suo50FaxTERbY FyZz0Cjphtv5ZHCXdH0lTuy910ArVZQ= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-368-7eX3hHVDP6OJiN7pcdAr2A-1; Thu, 26 Jan 2023 10:57:30 -0500 X-MC-Unique: 7eX3hHVDP6OJiN7pcdAr2A-1 Received: by mail-il1-f198.google.com with SMTP id n18-20020a056e02101200b0030f2b79c2ffso1404777ilj.20 for ; Thu, 26 Jan 2023 07:57:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rJEpaYXarlCa5mY2mox+K2PW+6++LhpOykQ3c/hj8Bg=; b=p55Z/t3IWiXP4Mk3r3bRYTYikPUBDdPlQEfWa0AW7U8LPjNc7d9PG11BbHVulKUWVA BaIKeizGlneJD0/ZgNE/q4+tOYXd2QPkJQHSLCNeUt6uRh8hp1LQLRCa4ncEXk+yp1Qy gNpAQNordsATI+qShEgLGnq5FmARx4T7twkKhyBJR75yhK7hIvNIf4eunMxfZKGBMO5f xFtYJLrgvruASzp27DRwv3gnycUiN57vcM3RDY3s47CFRrOq76MtMa8eCrxwmousj0IT PQlsn8uz2d3Ff5uj4zW1zvkjbHAA71BgcNRhiteCUJ7mNJd/G9kBg2ThK62qjM6q5RLL 5ESA== X-Gm-Message-State: AFqh2krDK16ewWg8hHNn7uUJHRblqNVYZ+PTXmINn0ZJiW9JHIJ8JVMy hIDmLJ3v2o1ZUlKcavH7+DFY32pH60hqz+oj4lXso0DM0N/UaByBG2b2iXBwJmZgM0rlWgGlk73 6qkdJf9aZrGCvAQfay+C538AIbCpBt2syKXk= X-Received: by 2002:a6b:f304:0:b0:6e3:75a:72e2 with SMTP id m4-20020a6bf304000000b006e3075a72e2mr2768257ioh.76.1674748649745; Thu, 26 Jan 2023 07:57:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXvwHqE8G5wbcD+65+7l9BUXVFmM4wBcZIEQfwA53x9DulanwHCqvkAxfFRoJtsPwVwnhJtkwfkboC1Ai+NzWLw= X-Received: by 2002:a6b:f304:0:b0:6e3:75a:72e2 with SMTP id m4-20020a6bf304000000b006e3075a72e2mr2768253ioh.76.1674748649423; Thu, 26 Jan 2023 07:57:29 -0800 (PST) MIME-Version: 1.0 References: <20230119160318.3868439-1-klember@redhat.com> <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org> In-Reply-To: <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org> From: Kalev Lember Date: Thu, 26 Jan 2023 16:57:18 +0100 Message-ID: Subject: Re: [PATCH] find-debuginfo: Pass -j down to dwz To: Mark Wielaard Cc: debugedit@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000056616805f32cce94" X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000056616805f32cce94 Content-Type: text/plain; charset="UTF-8" On Thu, Jan 26, 2023 at 3:34 PM Mark Wielaard wrote: > Hi Kalev, > Hi Mark, > Aha, you want to reduce the default parallelism (processors / 2)? > Yes, exactly! We have the following in webkitgtk, which basically just passes -j1 on low memory builders: # Require 32 GB of RAM per vCPU for debuginfo processing. 16 GB is not enough. %global _find_debuginfo_opts %limit_build -m 32768 > diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in > > index b07a52f..8cc1bfd 100755 > > --- a/scripts/find-debuginfo.in > > +++ b/scripts/find-debuginfo.in > > @@ -585,7 +585,7 @@ if $run_dwz \ > > dwz_multifile_suffix=".${dwz_multifile_idx}" > > done > > dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}" > > - dwz_opts="-h -q -r" > > + dwz_opts="-h -q -r -j ${n_jobs}" > > [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = "false" ] > \ > > && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}" > > mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz" > > I agree with Panu that a configure check would be nice to make sure the > installed dwz does support -j. Would the attached patch work for you? > That looks perfect to me. Thanks a lot! Can you also apply it to the rawhide package, please? That way I can confirm if it actually works on actual koji builders and see if we can get webkitgtk building right. Thanks, Kalev --00000000000056616805f32cce94--