From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) by sourceware.org (Postfix) with ESMTPS id EA4263858CDA for ; Thu, 10 Nov 2022 18:28:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA4263858CDA Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lsferreira.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lsferreira.net Date: Thu, 10 Nov 2022 18:28:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lsferreira.net; s=protonmail; t=1668104923; x=1668364123; bh=HVla38f5URlpij2hd5VPfUh9qQpCCgb+Q2uxh3PkA4c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=X891Hh/lRApVXIpNvOxSXW8iSYPRHTq9kGSOe1x4Jl3U9/bwmxUjvKAW9cWmjFq/M ijXxabaU/JoBrvR4pgteEciE7UpoRUMAcanIXbl5UWLzPOhvYXyJWQJfrymUQQCGK1 nrN1FLcdg+29+vWyD57YCjef+HqhW39yrCF/9/MDLp1Da6Q7RgVFpSoGmwDsZs1Yym AgJFgJ81jI21GbN6ACoJViCbItzEm5eZwcpwlvuD5cz2jGmjgCtYCmLfnw3/CpXfcA E+809lb7Uq9OrLRG6LDrNc+p0tB5aEVIGSrF8q0PgrLZtiDBxGvmSwuGdowFgnvTkS mVVPZ9g+Q2T0Q== To: =?utf-8?Q?Lu=C3=ADs_Ferreira?= From: contact@lsferreira.net Cc: debugedit@sourceware.org Subject: Re: [PATCH] debugedit: Don't hang on DW_FORM_strx references Message-ID: In-Reply-To: <20221110181759.63673-1-contact@lsferreira.net> References: <20221110181759.63673-1-contact@lsferreira.net> Feedback-ID: 49933900:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TO_EQ_FM_DIRECT_MX,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Related to issue https://sourceware.org/bugzilla/show_bug.cgi?id=3D28728 an= d its duplicate https://sourceware.org/bugzilla/show_bug.cgi?id=3D29773 . ------- Original Message ------- On Thursday, November 10th, 2022 at 6:17 PM, Lu=C3=ADs Ferreira wrote: >=20 >=20 > Compilers that generate DWARF5 can write to .debug_info a DW_FORM_strx > reference. The code seem to handle it but hangs on the abbreviation > sanity check. >=20 > Signed-off-by: Lu=C3=ADs Ferreira contact@lsferreira.net >=20 > --- > tools/debugedit.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/tools/debugedit.c b/tools/debugedit.c > index d82ae5a..4450b34 100644 > --- a/tools/debugedit.c > +++ b/tools/debugedit.c > @@ -778,12 +778,17 @@ no_memory: > || form =3D=3D DW_FORM_line_strp > || form =3D=3D DW_FORM_implicit_const > || form =3D=3D DW_FORM_addrx > + || form =3D=3D DW_FORM_strx > || form =3D=3D DW_FORM_loclistx > || form =3D=3D DW_FORM_rnglistx > || form =3D=3D DW_FORM_addrx1 > || form =3D=3D DW_FORM_addrx2 > || form =3D=3D DW_FORM_addrx3 > - || form =3D=3D DW_FORM_addrx4))) > + || form =3D=3D DW_FORM_addrx4 > + || form =3D=3D DW_FORM_strx1 > + || form =3D=3D DW_FORM_strx2 > + || form =3D=3D DW_FORM_strx3 > + || form =3D=3D DW_FORM_strx4))) > { > error (0, 0, "%s: Unknown DWARF DW_FORM_0x%x", dso->filename, >=20 > form); > -- > 2.38.1