From: Mark Wielaard <mark@klomp.org>
To: debugedit@sourceware.org
Cc: fche@redhat.com
Subject: Re: [PATCH] Record and write files in read_dwarf5_line_entries.
Date: Mon, 12 Jul 2021 22:31:10 +0200 [thread overview]
Message-ID: <YOymjrytCBLkecBI@wildebeest.org> (raw)
In-Reply-To: <20210705163504.27225-1-mark@klomp.org>
Hi,
On Mon, Jul 05, 2021 at 06:35:04PM +0200, Mark Wielaard wrote:
> Without giving -d /foo/build/bar debugedit wouldn't actually output
> any file from the line number table for DWARF5.
>
> * tools/debugedit.c (read_dwarf5_line_entries): Don't make
> collecting_dirs and writing_files depend on dest_dir. Always
> read idx for strp or line_strp on phase 0. comp_dir_len is
> zero when comp_dir is NULL.
> * tests/debugedit.at: Add source list mode tests for DWARF4
> and DWARF5.
Pushed.
> https://bugzilla.redhat.com/show_bug.cgi?id=1966987
Although I added test cases to show this patch fixes a real bug I am
not 100% sure it also fixes the bug reported in the above bug report.
Cheers,
Mark
prev parent reply other threads:[~2021-07-12 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 16:35 Mark Wielaard
2021-07-12 20:31 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOymjrytCBLkecBI@wildebeest.org \
--to=mark@klomp.org \
--cc=debugedit@sourceware.org \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).