From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id D76873853811 for ; Mon, 12 Jul 2021 20:31:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D76873853811 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x18.wildebeest.org [172.31.17.154]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 67BF5300064F; Mon, 12 Jul 2021 22:31:11 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 04DA02E80578; Mon, 12 Jul 2021 22:31:10 +0200 (CEST) Date: Mon, 12 Jul 2021 22:31:10 +0200 From: Mark Wielaard To: debugedit@sourceware.org Cc: fche@redhat.com Subject: Re: [PATCH] Record and write files in read_dwarf5_line_entries. Message-ID: References: <20210705163504.27225-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210705163504.27225-1-mark@klomp.org> X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: debugedit@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: debugedit development mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2021 20:31:15 -0000 Hi, On Mon, Jul 05, 2021 at 06:35:04PM +0200, Mark Wielaard wrote: > Without giving -d /foo/build/bar debugedit wouldn't actually output > any file from the line number table for DWARF5. > > * tools/debugedit.c (read_dwarf5_line_entries): Don't make > collecting_dirs and writing_files depend on dest_dir. Always > read idx for strp or line_strp on phase 0. comp_dir_len is > zero when comp_dir is NULL. > * tests/debugedit.at: Add source list mode tests for DWARF4 > and DWARF5. Pushed. > https://bugzilla.redhat.com/show_bug.cgi?id=1966987 Although I added test cases to show this patch fixes a real bug I am not 100% sure it also fixes the bug reported in the above bug report. Cheers, Mark