From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=leUn=MZ=klomp.org=mark@sourceware.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
	by sourceware.org (Postfix) with ESMTPS id 400E1384DD3E
	for <debugedit@sourceware.org>; Wed, 22 May 2024 14:02:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 400E1384DD3E
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 400E1384DD3E
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716386531; cv=none;
	b=gwosx4+YNtRsk9i8Phrhb9AQ8j55caH4zjFwcEU4R5YLPob1Fjt43HUt4e5P4qtZad8IHzn7jxf/uXD/ZwP46S9fB6x1WEM6W/tkGRJKD4bG/hsgufbjPRsNA+HDFFQCF7f8b0iwKpaPkUQil7ZF9h67pajIRnBIloMK8RZArS8=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1716386531; c=relaxed/simple;
	bh=hQgauHOpa4dIkVg0E7e7+4YOi8b3oj/IEzhz6jEWNkU=;
	h=Message-ID:Subject:From:To:Date:MIME-Version; b=hWCULcOMD302EG48XxocFsSireNruIUFOlynSkRgcZI6vYNdkcmmFBGYF3y3EPlh1COpaYWUTmT+ma0y7/cMSqj9iNCSVrwc03ZkuxUncG4KtuKo3VVGV0CmuI+nwjr+kFWjRHQI7TwvlK3vdyyqZb12MeGj+iizwzfIMOGERZ0=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174])
	(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by gnu.wildebeest.org (Postfix) with ESMTPSA id 4F6B630003AE
	for <debugedit@sourceware.org>; Wed, 22 May 2024 16:02:08 +0200 (CEST)
Received: by r6.localdomain (Postfix, from userid 1000)
	id 1A636340383; Wed, 22 May 2024 16:02:08 +0200 (CEST)
Message-ID: <adb994b09c85732e05871edf25406b4d6b5407ff.camel@klomp.org>
Subject: Re: [PATCH 2/2] debugedit: Handle DW_MACRO_{define,undef}_strx
From: Mark Wielaard <mark@klomp.org>
To: debugedit@sourceware.org
Date: Wed, 22 May 2024 16:02:08 +0200
In-Reply-To: <20240519210548.183878-2-mark@klomp.org>
References: <20240519210548.183878-1-mark@klomp.org>
	 <20240519210548.183878-2-mark@klomp.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
MIME-Version: 1.0
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <debugedit.sourceware.org>

Hi,

On Sun, 2024-05-19 at 23:05 +0200, Mark Wielaard wrote:
> For DW_MACRO_{define,undef}_strx we need to record the string index of
> the macro. Since this is read through the .debug_str_offets we need to
> know the relevant str_offsets_base of the CU associated with the macro
> table. Add a macros_offs field to struct CU. Set this in when seeing a
> DW_AT_macros. And make sure relocations against .debug_macros are
> resolved when handling ET_REL files.
>=20
> Now all (macro) tests pass with CC=3Dclang even when clang defaults to
> -gdwarf-5. The .debug_types tests are skipped because clang doesn't
> emit that section.

Pushed to main. Hopefully all builders will now be green!

Cheers,

Mark