From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A28413858D3C for ; Thu, 26 Jan 2023 15:21:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A28413858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674746499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yh2LVKwIYVXb4DH0AUzWnY+GidHCaw5q7M000yEs83c=; b=LN0y/SOhUqWzUrApDs6f6PT90oHDDxUaxDgm69Gtv+k/hJBW60JyrYsus9KHTbA8P8IIqu RAiULv5XG3pHSxmA+iNDTt17qp4EafG0NiOI5nT2vMi/oYCiO67Weu8Uvd0k+Oes3OMru9 baeS262UEwoedKLYyYQ3at+Qzdb9f9E= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-518-OVe9ldM6OAGrkkCRJv_2hQ-1; Thu, 26 Jan 2023 10:21:38 -0500 X-MC-Unique: OVe9ldM6OAGrkkCRJv_2hQ-1 Received: by mail-vk1-f200.google.com with SMTP id u187-20020a1fabc4000000b003ca3e899f8fso754652vke.22 for ; Thu, 26 Jan 2023 07:21:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yh2LVKwIYVXb4DH0AUzWnY+GidHCaw5q7M000yEs83c=; b=GM3kDzWvCD3VY5stUmfslQBsZyE+pVaDe7Ycyd3pxqHZJuYkNpvxXmrjdpZWUmISh7 5qS08RigOvtLd3xYrJy/hKtPwlhE6QxOZ5N+MM8z+igZjMXv8aOe8Ebjzhp0uSB4JtfM joy7BkxiYNxtowP3mVNTtV/ousgDaCNFbb6N6D4feZkDAkcpwjTr4N6sEiMIjwcGFk8A vvjyWculTbpbJEx8ii3HBesEZIuJaCGFiQhwAjYMF4EJZ5fPIZH8KTQNw55eh7hVllkZ 5HURt7a2ipL2nakyfihm2a+ZwxUOmPyBv43kB/KtoCqY5dbQ5U5i5LeOvwZ2fVnp895G RuRA== X-Gm-Message-State: AO0yUKXFEQw0FX0/71PaBGEolOOB2ktROxrdUt6afwCDl/e/KOz/81a5 pR4o9t5rTqMELnVVKtivTj2tm/M1ZAgZjhzAZKdGMTtLuecqFeyaiWZ2ZJhf3N0iVf+tvZch/Ey zUbrmRBD2B6M35rTrM9g= X-Received: by 2002:a05:6102:5c:b0:3e8:a271:da6 with SMTP id k28-20020a056102005c00b003e8a2710da6mr1011883vsp.15.1674746497557; Thu, 26 Jan 2023 07:21:37 -0800 (PST) X-Google-Smtp-Source: AK7set+IEsKU8VlZZmIUn/rIbIDrTrMNfqVRog+aU+IiD4aaSWns5aeldwc+7IZwZT3bxk92hWSHSw== X-Received: by 2002:a05:6102:5c:b0:3e8:a271:da6 with SMTP id k28-20020a056102005c00b003e8a2710da6mr1011854vsp.15.1674746497148; Thu, 26 Jan 2023 07:21:37 -0800 (PST) Received: from [10.16.222.26] (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id a191-20020ae9e8c8000000b006ee949b8051sm1057427qkg.51.2023.01.26.07.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 07:21:35 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 10:21:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] scripts/find-debuginfo.in: Add --no-per-file-msg To: Mark Wielaard , debugedit@sourceware.org References: <20230123202737.3632441-1-prarit@redhat.com> <345248abd55a2ebc9aa89f3d87f9ce0405b8caa5.camel@klomp.org> From: Prarit Bhargava In-Reply-To: <345248abd55a2ebc9aa89f3d87f9ce0405b8caa5.camel@klomp.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/26/23 10:02, Mark Wielaard wrote: > Hi Prarit, > > On Mon, 2023-01-23 at 15:27 -0500, Prarit Bhargava wrote: >> Projects with a large number of compiled files end up with a large number >> of 'extracting debug info from' messages in the build log. In the case of >> the Fedora kernel these messages account for 8504 lines in the log, or 61% >> of the entire log [1]. >> >> Removing these lines make the log easier to view and comprehend for some >> projects, however, not all projects will want to silence these messages so >> suppressing them must be optional. >> >> Add a --no-per-file-msg which allows users to disable the per file >> scanning message and in its place output a single general message in the >> log. > > I appreciate the idea, but I think it is better to have a more standard > -q, --quiet option that simply suppresses all none error/warnings. > find-debuginfo already has too many specialized options IMHO. > Heh, I thought about doing this but wasn't sure if there needed to be a quiet option. It's good to know you're open to this idea. > Besides this "per file" output that is just these three extra output > lines: > > echo "symlinked /usr/lib/debug$t to /usr/lib/debug${f}.debug" > echo "hard linked $link to $debugfn" > echo "original debug info size: ${size_before}kB, size after > compression: ${size_after}kB" > > (For that last one, you can then also hide the size_before > and size_after calculations behind $quiet &&) I'll look at this and post a --quiet option. Thanks, P.