From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 228033858D1E for ; Fri, 20 Jan 2023 11:27:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 228033858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674214064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h5AX8rpQP7POZdKSEIZbZjdqkmLATgzOotwlAANiQas=; b=LoUsEyYQseLQQjaQmsNQSKl7nTlAD2qaKS8UsBBJEo/54t3NtbRtL2UNZWwBa3YOWE7S8w dlkzMRmUygGG7m23sgdRPIm6Vv4fUj/8lY+q7i3kO5YbTFGKFoHQpiJoJCdUA6BVLhbRlB TXiIQb/x3GRUNT6p5ijnzGHjWLqObDE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-313-ErzuE83fPW-z92guiyj-cA-1; Fri, 20 Jan 2023 06:27:43 -0500 X-MC-Unique: ErzuE83fPW-z92guiyj-cA-1 Received: by mail-wm1-f69.google.com with SMTP id bg24-20020a05600c3c9800b003db0ddddb6fso2879908wmb.0 for ; Fri, 20 Jan 2023 03:27:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h5AX8rpQP7POZdKSEIZbZjdqkmLATgzOotwlAANiQas=; b=GsGYHV/WSKXYBSHicYWt7szkhJ3D4FXkyU3IxzxE/rrEyrY1vgS4WAk5OJL+wG50ly 7LVyg9hzZ2gFlvhBY6MpbbXrQp14YbJ5F7+UiEMoEGhvMEglJWXPX1gUEA7tx4gOFhtw vC3r4h7KEawVIoCKwdcjK2IKbwHEkJBsU58Ca+YZlQfw++SDrflMJ1zMxjOrFusw08tu PCs5MOCpu03jlbdCShVRnhoyXL1FDJVdTPG8j1Z+qHuEwjR3Sec6jKYi6jbnCR8CI6xS 0v1TJwGGuDN0oMvORol2dz8or7gXIcHGarLw5IL2HaUaDfN4ZjM7juTJLNv7tQKPjO8x 8nRw== X-Gm-Message-State: AFqh2kpDpP4IDAbEZoRwaOdatLbatAz60yycqJ+CePQADGwCsnF8R3Eo 06tYsM10FnnwSkNj4haJVDw2DLlzzkZBNIkC/975/FgPeq+8DKrlvPX4p0+J7PeIunYrViYrFxS 9FBDIMtMDUwmi+FEmKr0= X-Received: by 2002:a05:600c:540c:b0:3da:fa18:a535 with SMTP id he12-20020a05600c540c00b003dafa18a535mr13869932wmb.29.1674214061935; Fri, 20 Jan 2023 03:27:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXuJxNZ3UFfrRlvGocYIa8sdgQoxIC08717QdjvWdw5ezeDQ0vlUOyzzr9wm6Aip3Bi8XjEUSA== X-Received: by 2002:a05:600c:540c:b0:3da:fa18:a535 with SMTP id he12-20020a05600c540c00b003dafa18a535mr13869922wmb.29.1674214061771; Fri, 20 Jan 2023 03:27:41 -0800 (PST) Received: from [192.168.100.50] (85-76-8-83-nat.elisa-mobile.fi. [85.76.8.83]) by smtp.gmail.com with ESMTPSA id hg8-20020a05600c538800b003d974076f13sm2000319wmb.3.2023.01.20.03.27.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 03:27:41 -0800 (PST) Message-ID: Date: Fri, 20 Jan 2023 13:27:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] find-debuginfo: Pass -j down to dwz To: Kalev Lember Cc: debugedit@sourceware.org References: <20230119160318.3868439-1-klember@redhat.com> From: Panu Matilainen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/20/23 12:27, Kalev Lember wrote: > On Fri, Jan 20, 2023 at 9:40 AM Panu Matilainen > wrote: > > On 1/19/23 18:03, Kalev Lember wrote: > > Now that dwz 0.15 supports parallel jobs, add a way to control it > from > > here. find-debuginfo already has a -j parameter so we can just > extend it > > and pass the value down to dwz as well. > > > > This should fix building large packages on memory constrained > builders, > > such as webkitgtk on s390x in Fedora koji build system, where we > can now > > use the -j option to tune down parallelism to avoid running out of > > memory during dwz run. > > > > Signed-off-by: Kalev Lember > > > --- > >   scripts/find-debuginfo.in | 2 +- > >   1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/find-debuginfo.in > b/scripts/find-debuginfo.in > > index b07a52f..8cc1bfd 100755 > > --- a/scripts/find-debuginfo.in > > +++ b/scripts/find-debuginfo.in > > @@ -585,7 +585,7 @@ if $run_dwz \ > >         dwz_multifile_suffix=".${dwz_multifile_idx}" > >       done > > >  dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}" > > -    dwz_opts="-h -q -r" > > +    dwz_opts="-h -q -r -j ${n_jobs}" > >       [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = > "false" ] \ > >         && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}" > >       mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz" > > This is so new, even Fedora 37 doesn't have it yet. I tend to think > find-debuginfo should be a bit conservative about the assumptions it > makes about external tools. > > > Can we do some kind of configure check then and require the latest dwz? > Or add this as a downstream patch in rawhide? > > The problem is that new dwz is already in rawhide and it broke webkitgtk > builds due to too much memory use. The ppc64le and s390x builders just > don't have enough memory now to do dwz on webkitgtk. Passing down the -j > option would help us control the memory use to get the builds going again. > Oh, if rawhide needs this then rawhide needs this, I don't mind that at all. I just think that upstream find-debuginfo shouldn't assume "latest everything" any more than rpm can do so. configure-time check seems reasonable to me. - Panu -