From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: debugedit@sourceware.org
Subject: [Bug debugedit/27890] tests using CFLAGS/LDFLAGS causes testsuite failures
Date: Mon, 05 Jul 2021 15:11:34 +0000 [thread overview]
Message-ID: <bug-27890-13298-tYTFVTtFE0@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27890-13298@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=27890
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |mark at klomp dot org
Status|NEW |ASSIGNED
--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
To fix this I intend to push something like the following:
diff --git a/tests/atlocal.in b/tests/atlocal.in
index a45edac..0eec351 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -3,10 +3,12 @@
PATH=@abs_builddir@:@abs_top_builddir@:$top_srcdir:$srcdir:$PATH
+# We do use the CC and LD found by configure, but explicitly keep
+# CFLAGS and LDFLAGS empty because the tests use specific flags.
CC="@CC@"
-CFLAGS="@CFLAGS@"
+CFLAGS=""
LD="@LD@"
-LDFLAGS="@LDFLAGS@"
+LDFLAGS=""
GDWARF_5_FLAG=@GDWARF_5_FLAG@
GZ_NONE_FLAG=@GZ_NONE_FLAG@
It would still allow using different compilers/linkers, but not to override the
CFLAGS/LDFLAGS for the tests themselves (unless you edit atlocal by hand.
Does the above seem reasonable?
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2021-07-05 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:10 [Bug debugedit/27890] New: " mark at klomp dot org
2021-05-20 13:34 ` [Bug debugedit/27890] " doko at debian dot org
2021-05-20 13:47 ` ldv at sourceware dot org
2021-07-05 15:11 ` mark at klomp dot org [this message]
2021-07-12 20:21 ` mark at klomp dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27890-13298-tYTFVTtFE0@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=debugedit@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).