From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 6DE723858C98; Thu, 21 Mar 2024 11:46:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DE723858C98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1711021599; bh=BKmQhor7qM7EkuhQmlUDmJ7hyslNL/o9t00jT9wZb1c=; h=From:To:Subject:Date:In-Reply-To:References:From; b=oOi9p1uOq6SIUMsvM1mRo7kthXQiC9o0DIkBdPxMq7N9PTz6v6V7i1V80eqIPD+nM 0K5vQNO39DU2cruKHlKCPqJ8Q8WLEG87se4oT8tD+FUuEZjG7pIzMgbFBeBZqBoigx PnttoT5OtsaYyZcFeME/71nasM+Qg//exCyS99Ns= From: "mark at klomp dot org" To: debugedit@sourceware.org Subject: [Bug debugedit/31504] debugedit writes out ELF file even when nothing has been updated Date: Thu, 21 Mar 2024 11:46:38 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: debugedit X-Bugzilla-Component: debugedit X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31504 --- Comment #3 from Mark Wielaard --- (In reply to Allan McRae from comment #2) > This partially fixes the issue we are seeing in Arch Linux.=20=20 >=20 > Debugedit keeps the extra data when using: >=20 > LANG=3DC debugedit --no-recompute-build-id \ > --list-file /dev/stdout "$1" Thanks for testing. > But still removes the data when using: >=20 > LANG=3DC debugedit --no-recompute-build-id \ > --base-dir "${srcdir}" \ > --dest-dir "${dbgsrcdir}" \ > --list-file /dev/stdout "$1" Right. That is kind of expected since you are explicitly asking with --dest= -dir to rewrite the DWARF debuginfo. > This happens even when there are no source files found, so debugedit would > make no changes. I can add a check to see if there actually were any changes and if there ar= en't simply not call elf_update at all. But I suspect that is really a corner ca= se that doesn't occur that often. At least why would you call debugedit explic= itly asking to rewrite things and then expect it to not actually do that? --=20 You are receiving this mail because: You are on the CC list for the bug.=