public inbox for
 help / color / mirror / Atom feed
From: Mark Wielaard <>
To: "Dmitry V. Levin" <>,
Subject: Re: [PATCH] debugedit: fix exit status in case of wrong number of arguments
Date: Tue, 23 Mar 2021 14:56:56 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Dmitry,

On Mon, 2021-03-22 at 20:00 +0000, Dmitry V. Levin wrote:
> Print error diagnostics to stderr and exit with status EXIT_FAILURE
> when the number of arguments is not equal to 1.
> * tools/debugedit.c (usage): Add "error" argument, print usageText
> to stderr and exit with status EXIT_FAILURE if error is set to true.
> All callers updated.
> * tests/ Check debugedit usage.
> Fixes: 5200953d5a65 ("Initial build system. Remove rpm and popt
> dependencies.")
> Signed-off-by: Dmitry V. Levin <>

Looks good, this makes usage similar to help.
And thanks for the new testcase.

Pushed to main.


      reply	other threads:[~2021-03-23 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 20:00 Dmitry V. Levin
2021-03-23 13:56 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).