From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id 57714385701F
 for <debugedit@sourceware.org>; Tue, 23 Mar 2021 13:56:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 57714385701F
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 4040E302FB96;
 Tue, 23 Mar 2021 14:56:57 +0100 (CET)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id F0027413CEBD; Tue, 23 Mar 2021 14:56:56 +0100 (CET)
Message-ID: <c4abae9ea0d0f9f1c0fb40b59add81e779961a8c.camel@klomp.org>
Subject: Re: [PATCH] debugedit: fix exit status in case of wrong number of
 arguments
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>, debugedit@sourceware.org
Date: Tue, 23 Mar 2021 14:56:56 +0100
In-Reply-To: <20210322200000.GA2781@altlinux.org>
References: <20210322200000.GA2781@altlinux.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: debugedit@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: debugedit development mailing list <debugedit.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/debugedit>,
 <mailto:debugedit-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/debugedit/>
List-Post: <mailto:debugedit@sourceware.org>
List-Help: <mailto:debugedit-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/debugedit>,
 <mailto:debugedit-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2021 13:57:01 -0000

Hi Dmitry,

On Mon, 2021-03-22 at 20:00 +0000, Dmitry V. Levin wrote:
> Print error diagnostics to stderr and exit with status EXIT_FAILURE
> when the number of arguments is not equal to 1.
>=20
> * tools/debugedit.c (usage): Add "error" argument, print usageText
> to stderr and exit with status EXIT_FAILURE if error is set to true.
> All callers updated.
> * tests/debugedit.at: Check debugedit usage.
>=20
> Fixes: 5200953d5a65 ("Initial build system. Remove rpm and popt
> dependencies.")
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>

Looks good, this makes usage similar to help.
And thanks for the new testcase.

Pushed to main.

Mark