From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id A595C3858D39 for ; Tue, 28 Mar 2023 11:24:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A595C3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 885B4313AC9B; Tue, 28 Mar 2023 13:24:58 +0200 (CEST) Received: by r6.localdomain (Postfix, from userid 1000) id 3AB2534024A; Tue, 28 Mar 2023 13:24:58 +0200 (CEST) Message-ID: Subject: Re: [PATCH 1/3] debugedit: skip .debug_types tests if compiler doesn't generate section From: Mark Wielaard To: "Dmitry V. Levin" , debugedit@sourceware.org Date: Tue, 28 Mar 2023 13:24:58 +0200 In-Reply-To: <20230325113043.GA19701@altlinux.org> References: <20230324235807.2335399-1-mark@klomp.org> <20230325113043.GA19701@altlinux.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Dmitry, On Sat, 2023-03-25 at 14:30 +0300, Dmitry V. Levin wrote: > On Sat, Mar 25, 2023 at 12:58:05AM +0100, Mark Wielaard wrote: > > Some compilers don't generate a .debug_types section even when compilin= g > > with -fdebug-types-section. Skip testing the .debug_types tests in that > > case. > >=20 > > DEBUGEDIT_SETUP([-fdebug-types-section -gdwarf-4]) > > +AT_SKIP_IF([! $READELF -S ./foo.o ./subdir_bar/bar.o ./baz.o | grep -q= '.debug_types']) >=20 > Should it rather be grep -F -q? Yes, that (--fixed-strings) would indeed be better. Fixed in 3 places. Thanks, Mark