From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 335623858C52 for ; Fri, 20 Jan 2023 08:39:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 335623858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674203993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TpDaZcj+WtMZgwvroHbbtKAQ2bNzAtVPPKSBq0nBLDw=; b=H7NPXePfy+noIKAuHu7mTN6cBWlW3aTQ+Dy+DOCwPL0nbfjoz8PvFGajivYgWW7gXipl3j CyQm/kGVF+O30ucFB2kygiglU1cNJcCJPHfiJ45lDqxJNuPhw4cXnEWmNem44AoT4j06+e 2YvDo0ww/EPKA1xDEyXxNG4lezaDv+s= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-635-px_9tWT4M9K9bpB5oRIgvw-1; Fri, 20 Jan 2023 03:39:52 -0500 X-MC-Unique: px_9tWT4M9K9bpB5oRIgvw-1 Received: by mail-wm1-f72.google.com with SMTP id bg24-20020a05600c3c9800b003db0ddddb6fso2654763wmb.0 for ; Fri, 20 Jan 2023 00:39:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TpDaZcj+WtMZgwvroHbbtKAQ2bNzAtVPPKSBq0nBLDw=; b=zhJc38bgRxi5RgIlx2N134poTgXbfF+r79Cexq3suskLtMUjSyt6dWgVFQhHGf8vzr RWWZEhJKgXtEzUEd+fS3sm9G7hnSKXcDydghpE8W+suNxkFj8RMv1pBVRpoPdyCh8Jkz PBLleo5tnR6EOVqZvpiqcxIR2q45YFz/FREl6OOW0KoGV2eix76S2eDoSLVZ9NDKZ79u W8/aEQorTKJUXozf6v8EFEeBDRYOTjn5Y5l/4IZySS/S5k0mM+4PDF2ETAvCBn1C0o9m opOknZk8USwKz9ABg59QpQGetTFc19Z30Xc3WtlyYSZScYmfqnxMkRPfHK8phDCMg0// jC9Q== X-Gm-Message-State: AFqh2koK0VnWTP8Ga/j/lO0RJCUAnKFw9u7xmfbCZw3ARrjEYIREsThd i5eBoGsNY6/Gv1vNdVUc/fM0RN9OPiCaFFHrnHhBC7uewZ3LdsjpXED4uD2iZCsQ/xOJzmXAK5P mKmxlEWo2SZvKF4kOgxgDzNeYy86OQxZ/HdMK6mPbFlF85msclOl9yyg/36/nGRBYLLyvans= X-Received: by 2002:a05:600c:35d0:b0:3db:c4c:9224 with SMTP id r16-20020a05600c35d000b003db0c4c9224mr11505410wmq.3.1674203991308; Fri, 20 Jan 2023 00:39:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXunvZ9zNzNU8VydrzoCUCMMXwuRCiThA5V3NMBBhR0I8moUW+JI64PVHpnl3rZ+3xo12b4MgA== X-Received: by 2002:a05:600c:35d0:b0:3db:c4c:9224 with SMTP id r16-20020a05600c35d000b003db0c4c9224mr11505392wmq.3.1674203990922; Fri, 20 Jan 2023 00:39:50 -0800 (PST) Received: from [192.168.100.50] (85-76-8-83-nat.elisa-mobile.fi. [85.76.8.83]) by smtp.gmail.com with ESMTPSA id i10-20020a05600011ca00b002bf94527b9esm137685wrx.85.2023.01.20.00.39.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 00:39:50 -0800 (PST) Message-ID: Date: Fri, 20 Jan 2023 10:39:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] find-debuginfo: Pass -j down to dwz To: debugedit@sourceware.org References: <20230119160318.3868439-1-klember@redhat.com> From: Panu Matilainen In-Reply-To: <20230119160318.3868439-1-klember@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/19/23 18:03, Kalev Lember wrote: > Now that dwz 0.15 supports parallel jobs, add a way to control it from > here. find-debuginfo already has a -j parameter so we can just extend it > and pass the value down to dwz as well. > > This should fix building large packages on memory constrained builders, > such as webkitgtk on s390x in Fedora koji build system, where we can now > use the -j option to tune down parallelism to avoid running out of > memory during dwz run. > > Signed-off-by: Kalev Lember > --- > scripts/find-debuginfo.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in > index b07a52f..8cc1bfd 100755 > --- a/scripts/find-debuginfo.in > +++ b/scripts/find-debuginfo.in > @@ -585,7 +585,7 @@ if $run_dwz \ > dwz_multifile_suffix=".${dwz_multifile_idx}" > done > dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}" > - dwz_opts="-h -q -r" > + dwz_opts="-h -q -r -j ${n_jobs}" > [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = "false" ] \ > && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}" > mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz" This is so new, even Fedora 37 doesn't have it yet. I tend to think find-debuginfo should be a bit conservative about the assumptions it makes about external tools. - Panu -