public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Tom Stellard <tstellar@redhat.com>, debugedit@sourceware.org
Subject: Re: [PATCH] debugedit: Skip relocations with missing symbol/section offset.
Date: Mon, 05 Jul 2021 16:38:37 +0200	[thread overview]
Message-ID: <e79abc8fb03747ab63a56c568e60fa2682ba3d49.camel@klomp.org> (raw)
In-Reply-To: <48d48fc3-0875-04f9-63f3-1e565335d540@redhat.com>

Hi Tom,

On Thu, 2021-07-01 at 13:12 -0700, Tom Stellard wrote:
> On 7/1/21 3:05 AM, Mark Wielaard wrote:
> > We tried to handle relocations that didn't have a symbol associated
> > with any section.  The would cause a message like: "Unhandled
> > relocation 1 in .debug_info section".  Which wasn't that helpful
> > either. So skip relocations without an associated symbol section
> > index
> > and improve the error message a little.
> > 
> >      * debugedit.c (setup_relbuf): Continue when sym.st_shndx == 0.
> >      Add relocation index to error message.
> > 
> 
> I tested this and can confirm that it fixes my issue with the
> Fedora kernel builds with clang and LTO.

Thanks for testing, pushed to main.

Note that although debugedit now silently ignores these noop
relocations they do still produce useless/broken DWARF.

Cheers,

Mark

      reply	other threads:[~2021-07-05 14:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01 10:05 Mark Wielaard
2021-07-01 20:12 ` Tom Stellard
2021-07-05 14:38   ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e79abc8fb03747ab63a56c568e60fa2682ba3d49.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=debugedit@sourceware.org \
    --cc=tstellar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).