From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 2950E385DC10 for ; Mon, 5 Jul 2021 14:38:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2950E385DC10 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 1234E302FBA6; Mon, 5 Jul 2021 16:38:37 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 7339E401EDA3; Mon, 5 Jul 2021 16:38:37 +0200 (CEST) Message-ID: Subject: Re: [PATCH] debugedit: Skip relocations with missing symbol/section offset. From: Mark Wielaard To: Tom Stellard , debugedit@sourceware.org Date: Mon, 05 Jul 2021 16:38:37 +0200 In-Reply-To: <48d48fc3-0875-04f9-63f3-1e565335d540@redhat.com> References: <20210701100519.321801-1-mark@klomp.org> <48d48fc3-0875-04f9-63f3-1e565335d540@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: debugedit@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: debugedit development mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2021 14:38:40 -0000 Hi Tom, On Thu, 2021-07-01 at 13:12 -0700, Tom Stellard wrote: > On 7/1/21 3:05 AM, Mark Wielaard wrote: > > We tried to handle relocations that didn't have a symbol associated > > with any section. The would cause a message like: "Unhandled > > relocation 1 in .debug_info section". Which wasn't that helpful > > either. So skip relocations without an associated symbol section > > index > > and improve the error message a little. > >=20 > > * debugedit.c (setup_relbuf): Continue when sym.st_shndx =3D=3D 0. > > Add relocation index to error message. > >=20 >=20 > I tested this and can confirm that it fixes my issue with the > Fedora kernel builds with clang and LTO. Thanks for testing, pushed to main. Note that although debugedit now silently ignores these noop relocations they do still produce useless/broken DWARF. Cheers, Mark