From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id D7E0639574CD
 for <debugedit@sourceware.org>; Thu, 29 Apr 2021 12:26:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D7E0639574CD
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 921933075E92;
 Thu, 29 Apr 2021 14:26:13 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 46BE5413CB92; Thu, 29 Apr 2021 14:26:13 +0200 (CEST)
Message-ID: <f87b0076afcf6bb1814f15a9405d2a9127fdb03e.camel@klomp.org>
Subject: Re: [PATCH 1/2] debugedit: strip extra newline characters from
 diagnostic messages
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>, debugedit@sourceware.org
Date: Thu, 29 Apr 2021 14:26:13 +0200
In-Reply-To: <20210426200000.GA12328@altlinux.org>
References: <20210426200000.GA12328@altlinux.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: debugedit@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: debugedit development mailing list <debugedit.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/debugedit>,
 <mailto:debugedit-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/debugedit/>
List-Post: <mailto:debugedit@sourceware.org>
List-Help: <mailto:debugedit-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/debugedit>,
 <mailto:debugedit-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2021 12:26:16 -0000

Hi Dmitry,

On Mon, 2021-04-26 at 20:00 +0000, Dmitry V. Levin wrote:
> Since the output produced by error() is already terminated by a newline
> character, no newline terminating characters are needed in diagnostic
> messages printed using error().
>=20
> * tools/debugedit.c (main): Remove terminating newline characters from
> format strings passed to error().

Thanks, that makes sense.

Pushed,

Mark